From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Grazvydas Ignotas <notasas@gmail.com>,
Jarkko Nikula <jhnikula@gmail.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/2] ASoC: Return proper error for omap3pandora_soc_init
Date: Wed, 24 Nov 2010 10:49:10 +0000 [thread overview]
Message-ID: <1290595750.3332.5.camel@odin> (raw)
In-Reply-To: <1290583248.20639.1.camel@mola>
On Wed, 2010-11-24 at 15:20 +0800, Axel Lin wrote:
> Return PTR_ERR(omap3pandora_dac_reg) instead of 0 if regulator_get failed.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> sound/soc/omap/omap3pandora.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/omap/omap3pandora.c b/sound/soc/omap/omap3pandora.c
> index bff9864..8047c52 100644
> --- a/sound/soc/omap/omap3pandora.c
> +++ b/sound/soc/omap/omap3pandora.c
> @@ -307,6 +307,7 @@ static int __init omap3pandora_soc_init(void)
> pr_err(PREFIX "Failed to get DAC regulator from %s: %ld\n",
> dev_name(&omap3pandora_snd_device->dev),
> PTR_ERR(omap3pandora_dac_reg));
> + ret = PTR_ERR(omap3pandora_dac_reg);
> goto fail3;
> }
>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next prev parent reply other threads:[~2010-11-24 10:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-24 7:20 [PATCH 1/2] ASoC: Return proper error for omap3pandora_soc_init Axel Lin
2010-11-24 7:23 ` [PATCH 2/2] ASoC: Fix resource reclaim for osk5912 Axel Lin
2010-11-24 8:33 ` Jarkko Nikula
2010-11-24 8:37 ` Varadarajan, Charulatha
2010-11-24 10:50 ` Liam Girdwood
2010-11-24 8:33 ` [PATCH 1/2] ASoC: Return proper error for omap3pandora_soc_init Jarkko Nikula
2010-11-24 10:49 ` Liam Girdwood [this message]
2010-11-24 11:30 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290595750.3332.5.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jhnikula@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=notasas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox