Re: [PATCH 1/3] jump label: add enabled/disabled state to jump label key entries

[Michael Ellerman <michael@ellerman.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1305 bytes --]

On Wed, 2010-11-24 at 10:53 -0500, Steven Rostedt wrote:
> On Wed, 2010-11-24 at 10:42 -0500, Jason Baron wrote:
> 
> > > And I think the only arch where you can do text pokes without cross-cpu
> > > synchronization is one that doesn't have SMP support.
> > > 
> > > 
> > 
> > is this really true?
> > 
> > The powerpc implementation uses patch_instruction():
> > 
> > 
> > arch/powerpc/lib/code-patching.c:
> > 
> > void patch_instruction(unsigned int *addr, unsigned int instr)
> > {
> >         *addr = instr;
> >         asm ("dcbst 0, %0; sync; icbi 0,%0; sync; isync" : : "r"
> > (addr));
> > }
> 
> Is this ever called outside of boot up? After SMP is enabled? (besides
> for creating trampolines, before they are used).

It is now :)

AFAIK it works fine, the icbi invalidates across all processors. The
only issue is that it's not precise, ie. another CPU might not see the
update immediately, but as soon as it takes an interrupt or something it
will.

What would suit us would be to have an arch callback that is called
after all the transforms for a particular jump label key have been made.
That way we could optimise the individual patches, and do a sync step at
the end, ie. when we want the effect of the patching to be globally
visible.

cheers



[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]