From: Chen Gong <gong.chen@linux.intel.com>
To: x86@kernel.org
Cc: hpa@zytor.com, ak@linux.intel.com, linux-kernel@vger.kernel.org,
Chen Gong <gong.chen@linux.intel.com>
Subject: [PATCH] x86/MCE: don't let EDAC bypass the handle from MCE
Date: Thu, 25 Nov 2010 16:46:33 +0800 [thread overview]
Message-ID: <1290674793-8346-1-git-send-email-gong.chen@linux.intel.com> (raw)
currently EDAC bypass userspace handler intentionally if it can
deal with it, but this kind of operation will confuse users.
Some errors such as memory errors will be decoded by EDAC but
userspace handler (such as mcelog) knows nothing about it. At
least the kernel should give userspace a chance to know what
happens.
Signed-off-by: Chen Gong <gong.chen@linux.intel.com>
---
arch/x86/kernel/cpu/mcheck/mce.c | 9 +--------
1 files changed, 1 insertions(+), 8 deletions(-)
diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c
index 7a35b72..78eba57 100644
--- a/arch/x86/kernel/cpu/mcheck/mce.c
+++ b/arch/x86/kernel/cpu/mcheck/mce.c
@@ -169,14 +169,7 @@ void mce_log(struct mce *mce)
for (;;) {
entry = rcu_dereference_check_mce(mcelog.next);
for (;;) {
- /*
- * If edac_mce is enabled, it will check the error type
- * and will process it, if it is a known error.
- * Otherwise, the error will be sent through mcelog
- * interface
- */
- if (edac_mce_parse(mce))
- return;
+ edac_mce_parse(mce);
/*
* When the buffer fills up discard new entries.
--
1.7.3.1.120.g38a18
next reply other threads:[~2010-11-25 8:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-25 8:46 Chen Gong [this message]
2010-11-25 9:41 ` [PATCH] x86/MCE: don't let EDAC bypass the handle from MCE Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290674793-8346-1-git-send-email-gong.chen@linux.intel.com \
--to=gong.chen@linux.intel.com \
--cc=ak@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox