From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Miguel Aguilar <miguel.aguilar@ridgerun.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Jarkko Nikula <jhnikula@gmail.com>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: davinci-vcif - fix a memory leak
Date: Thu, 25 Nov 2010 10:46:55 +0000 [thread overview]
Message-ID: <1290682015.3302.12.camel@odin> (raw)
In-Reply-To: <1290655994.30158.1.camel@mola>
On Thu, 2010-11-25 at 11:33 +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> sound/soc/davinci/davinci-vcif.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/davinci/davinci-vcif.c b/sound/soc/davinci/davinci-vcif.c
> index fb4cc1e..9d2afcc 100644
> --- a/sound/soc/davinci/davinci-vcif.c
> +++ b/sound/soc/davinci/davinci-vcif.c
> @@ -247,7 +247,10 @@ fail:
>
> static int davinci_vcif_remove(struct platform_device *pdev)
> {
> + struct davinci_vcif_dev *davinci_vcif_dev = dev_get_drvdata(&pdev->dev);
> +
> snd_soc_unregister_dai(&pdev->dev);
> + kfree(davinci_vcif_dev);
>
> return 0;
> }
Acked-by: Liam Girdwood <lrg@slimlogic.o.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next prev parent reply other threads:[~2010-11-25 10:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-25 3:33 [PATCH] ASoC: davinci-vcif - fix a memory leak Axel Lin
2010-11-25 10:46 ` Liam Girdwood [this message]
2010-11-25 11:12 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290682015.3302.12.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=jhnikula@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.aguilar@ridgerun.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox