From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Manuel Lauss <mano@roarinelk.homelinux.net>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: Call snd_soc_unregister_dais instead of snd_soc_unregister_dai in sh4_soc_dai_remove
Date: Thu, 25 Nov 2010 10:48:23 +0000 [thread overview]
Message-ID: <1290682103.3302.16.camel@odin> (raw)
In-Reply-To: <1290677035.1928.3.camel@mola>
On Thu, 2010-11-25 at 17:23 +0800, Axel Lin wrote:
> We call snd_soc_register_dais() in sh4_soc_dai_probe(),
> thus we should call snd_soc_unregister_dais() in sh4_soc_dai_remove().
>
> Otherwise, we got "too many arguments to function 'snd_soc_unregister_dai'"
> error message.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> sound/soc/sh/ssi.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/sh/ssi.c b/sound/soc/sh/ssi.c
> index 40bbdf1..05192d9 100644
> --- a/sound/soc/sh/ssi.c
> +++ b/sound/soc/sh/ssi.c
> @@ -387,7 +387,7 @@ static int __devinit sh4_soc_dai_probe(struct platform_device *pdev)
>
> static int __devexit sh4_soc_dai_remove(struct platform_device *pdev)
> {
> - snd_soc_unregister_dai(&pdev->dev, ARRAY_SIZE(sh4_ssi_dai));
> + snd_soc_unregister_dais(&pdev->dev, ARRAY_SIZE(sh4_ssi_dai));
> return 0;
> }
>
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next prev parent reply other threads:[~2010-11-25 10:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-25 9:23 [PATCH] ASoC: Call snd_soc_unregister_dais instead of snd_soc_unregister_dai in sh4_soc_dai_remove Axel Lin
2010-11-25 10:48 ` Liam Girdwood [this message]
2010-11-25 11:11 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290682103.3302.16.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mano@roarinelk.homelinux.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox