From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Stephane Eranian <eranian@google.com>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@elte.hu>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Julia Lawall <julia@diku.dk>, Tom Zanussi <tzanussi@gmail.com>,
linux-kernel@vger.kernel.org,
Matt Fleming <matt@console-pimps.org>
Subject: Re: [RFC PATCHv3] perf tools: add event grouping capability to "perf stat"
Date: Thu, 25 Nov 2010 15:02:00 +0100 [thread overview]
Message-ID: <1290693720.2145.34.camel@laptop> (raw)
In-Reply-To: <AANLkTinTNAwMCe_zu1snG1U5hSRafdBHQdzAr4e9nuWO@mail.gmail.com>
On Thu, 2010-11-25 at 14:19 +0100, Stephane Eranian wrote:
> I think using PERF_SAMPLE_READ may expose a problem in the
> perf.data format. To correctly parse a sample created with SAMPLE_READ,
> you need to know the attr.read_format. But for that you need to know the
> event which caused the sample, but for that you need the SAMPLE_ID,
> and you don't know if it's there or not. In other words, there is a chicken
> and egg problem.
>
> I think the issue is that PERF_RECORD_SAMPLE is missing a mandatory
> piece of information: overflow event ID. This must a mandatory field, not
> optional as it is today. It is okay when you have only one group, but we'd
> like to go beyond that.
I'm not sure I get it, there's both PERF_FORMAT_ID and PERF_SAMPLE_ID,
so afaict there's a working combination for what you want to do.
next prev parent reply other threads:[~2010-11-25 14:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-25 1:54 [RFC PATCHv3] perf tools: add event grouping capability to "perf stat" Corey Ashford
2010-11-25 6:32 ` Peter Zijlstra
2010-11-25 7:46 ` Frederic Weisbecker
2010-11-25 8:00 ` Peter Zijlstra
2010-11-25 8:10 ` Frederic Weisbecker
2010-11-25 9:16 ` Stephane Eranian
2010-11-25 13:19 ` Stephane Eranian
2010-11-25 13:19 ` Stephane Eranian
2010-11-25 13:22 ` Stephane Eranian
2010-11-25 14:02 ` Peter Zijlstra [this message]
2010-11-25 14:07 ` Stephane Eranian
2010-11-25 14:12 ` Peter Zijlstra
2010-11-25 14:18 ` Stephane Eranian
2010-11-25 14:22 ` Peter Zijlstra
2010-11-25 15:10 ` Lin Ming
2010-11-25 15:15 ` Peter Zijlstra
2010-11-25 15:19 ` Lin Ming
2010-11-25 16:49 ` Arnaldo Carvalho de Melo
2010-11-26 19:22 ` Corey Ashford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290693720.2145.34.camel@laptop \
--to=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=cjashfor@linux.vnet.ibm.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=julia@diku.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@console-pimps.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox