public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Milton Miller <miltonm@bga.com>
To: Zimny Lech <napohybelskurwysynom2010@gmail.com>,
	Valdis Kletnieks <Valdis.Kletnieks@vt.edu>,
	Greg KH <gregkh@suse.de>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: The longest build error ever, ever, ever seen :) (Re:linux-next: Tree for November 26)
Date: Sun, 28 Nov 2010 00:55:14 -0600	[thread overview]
Message-ID: <1290927314_21183@mail4.comsite.net> (raw)
In-Reply-To: <256560.1290881547@localhost>

On Sat Nov 27 2010 around 13:13:03 EST, Valdis Kletnieks wrote:
> On Sat, 27 Nov 2010 08:45:55 PST, Greg KH said:
> > On Sat, Nov 27, 2010 at 09:56:45AM +0100, Zimny Lech wrote:
> > > Ave!
> > >
> > > 2010/11/26 Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx>:
> > > > Hi all,
> > > >
> > >
> > > OMG, LOL, this one is awesome :) The longest build error ever, ever,
> > > ever seen! Fscking awesome, someone gets Guiness World Record :)
> > >
> > > LD drivers/staging/built-in.o
> > > drivers/staging/rtl8192e/built-in.o: In function `rtl8192_setBBreg':
> > > (.text+0xae00): multiple definition of `rtl8192_setBBreg'
> > > drivers/staging/rtl8192u/built-in.o:(.text+0xa1a0): first defined here
> >
> > You built both of these drivers into the kernel, which causes the
> > problem. Try building them as modules, or just one as a module, and
> > that will solve the problem.
> 
> We probably should create some Kconfig magic to prevent this situation?
> 
> depends (othermodule != 'y') || (myself != 'y')
> 
> or am I on the wrong track here?
> 

A simple

depends on !OTHERMODULE

allows either to be built-in or both to be modular.

It also documents what conflicts.

(see Menu dependencies in Documentation/kbuild/kconfig-language.txt)

milton

  parent reply	other threads:[~2010-11-28  6:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-27  8:56 The longest build error ever, ever, ever seen :) (Re: linux-next: Tree for November 26) Zimny Lech
2010-11-27 16:45 ` Greg KH
2010-11-27 18:12   ` Valdis.Kletnieks
2010-11-27 18:27     ` Greg KH
2010-11-27 21:21       ` Stephen Rothwell
2010-11-28  0:22         ` Greg KH
2010-11-28  6:55     ` Milton Miller [this message]
2010-12-01 18:30       ` The longest build error ever, ever, ever seen :) (Re:linux-next: " Randy Dunlap
2010-12-01 19:29         ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1290927314_21183@mail4.comsite.net \
    --to=miltonm@bga.com \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=napohybelskurwysynom2010@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox