From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Timur Tabi <timur@freescale.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
alsa-devel@alsa-project.org
Subject: Re: [PATCH 1/2] ASoC: Add missing dev_set_drvdata in mpc8610_hpcd_probe
Date: Mon, 29 Nov 2010 11:08:39 +0000 [thread overview]
Message-ID: <1291028919.3299.137.camel@odin> (raw)
In-Reply-To: <1291013698.19113.1.camel@mola>
On Mon, 2010-11-29 at 14:54 +0800, Axel Lin wrote:
> Otherwise, calling dev_get_drvdata in mpc8610_hpcd_remove returns NULL.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> sound/soc/fsl/mpc8610_hpcd.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/fsl/mpc8610_hpcd.c b/sound/soc/fsl/mpc8610_hpcd.c
> index 0d7dcf1..7d7847a 100644
> --- a/sound/soc/fsl/mpc8610_hpcd.c
> +++ b/sound/soc/fsl/mpc8610_hpcd.c
> @@ -498,6 +498,7 @@ static int mpc8610_hpcd_probe(struct platform_device *pdev)
> dev_err(&pdev->dev, "platform device add failed\n");
> goto error;
> }
> + dev_set_drvdata(&pdev->dev, sound_device);
>
> of_node_put(codec_np);
>
All
Acked-by: Liam Girdwood <lrg@slimlogic.co.uk>
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next prev parent reply other threads:[~2010-11-29 11:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-29 6:54 [PATCH 1/2] ASoC: Add missing dev_set_drvdata in mpc8610_hpcd_probe Axel Lin
2010-11-29 6:55 ` [PATCH 2/2] ASoC: Add missing dev_set_drvdata in p1022_ds_probe Axel Lin
2010-11-29 11:08 ` Liam Girdwood [this message]
2010-11-29 14:53 ` [PATCH 1/2] ASoC: Add missing dev_set_drvdata in mpc8610_hpcd_probe Timur Tabi
2010-11-29 16:12 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291028919.3299.137.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox