Re: [PATCH v4] sched: automated per session task groups

Ingo Molnar
2010-11-30T14:18:22Z

* Mike Galbraith <efault@gmx.de> wrote:

> On Mon, 2010-11-29 at 20:20 +0100, Ingo Molnar wrote:
> > * Mike Galbraith <efault@gmx.de> wrote:
> >
> > > > I know, from the testing so far we _thought_ it was fairly sane. Apparently
> > > > there's still some work to do.
> > >
> > > Damn thing bisected to:
> > >
> > > commit 92fd4d4d67b945c0766416284d4ab236b31542c4
> > > Merge: fe7de49 e53beac
> > > Author: Ingo Molnar <mingo@elte.hu>
> > > Date: Thu Nov 18 13:22:14 2010 +0100
> > >
> > > Merge commit 'v2.6.37-rc2' into sched/core
> > >
> > > Merge reason: Move to a .37-rc base.
> > >
> > > Signed-off-by: Ingo Molnar <mingo@elte.hu>
> > >
> > > 92fd4d4d67b945c0766416284d4ab236b31542c4 is the first bad commit
> >
> > Hm, i'd suggest to double check the two originator points:
> >
> > e53beac - is it really 'bad' ?
> > fe7de49 - is it really 'good'?
>
> Nope. I did a bisection this morning in text mode with a pipe-test
> based measurement proggy, and it bisected cleanly.
>
> 2069dd75c7d0f49355939e5586daf5a9ab216db7 is the first bad commit
>
> commit 2069dd75c7d0f49355939e5586daf5a9ab216db7
> Author: Peter Zijlstra <a.p.zijlstra@chello.nl>
> Date: Mon Nov 15 15:47:00 2010 -0800
>
> sched: Rewrite tg_shares_up)

Ok. And has this fixed it:

822bc180a7f7: sched: Fix unregister_fair_sched_group()

... or are there two bugs?

Thanks,

Ingo