public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Joe Perches <joe@perches.com>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: Add and use rdev_<level> macros
Date: Tue, 30 Nov 2010 15:15:39 +0000	[thread overview]
Message-ID: <1291130139.3293.18.camel@odin> (raw)
In-Reply-To: <1291125228.18026.32.camel@Joe-Laptop>

On Tue, 2010-11-30 at 05:53 -0800, Joe Perches wrote:
> On Tue, 2010-11-30 at 10:52 +0000, Mark Brown wrote:
> > On Mon, Nov 29, 2010 at 05:12:56PM -0800, Joe Perches wrote:
> > > Just to please broonie...
> > > Signed-off-by: Joe Perches <joe@perches.com>
> > As usual when fixing review issues please revise your original patch
> > rather than posting a fresh patch.
> 
> Here's an earlier comment:
> 
> On Thu, 2010-11-18 at 13:30 +0000, Mark Brown wrote:
> > This looks reasonable, please rebase on top of Daniel's patches and
> > submit it properly (with changelog and so on). 
> 
> Sometimes it's simpler for an upstream maintainer to do
> something like:
> 
> git am -s <patch1.mbox>
> patch -p1 < patch2.mbox
> git commit --amend file
> 
> instead of back and forthing.
> 
> ---
> Use rdev_<level> convenience macros to emit rdev_get_name(rdev)
> along with whatever format/arg... is supplied.
> 
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>  drivers/regulator/core.c |  146 ++++++++++++++++++++-------------------------
>  1 files changed, 65 insertions(+), 81 deletions(-)
> 

Applied.

Thanks

Liam
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk


      parent reply	other threads:[~2010-11-30 15:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-29 19:54 [PATCH] regulator: Add and use rdev_<level> macros Joe Perches
2010-11-29 22:00 ` Mark Brown
2010-11-30  1:12   ` [PATCH] regulator: Rename rdev_debug to rdev_dbg Joe Perches
2010-11-30 10:52     ` Mark Brown
2010-11-30 13:53       ` [PATCH] regulator: Add and use rdev_<level> macros Joe Perches
2010-11-30 14:23         ` Mark Brown
2010-11-30 15:15         ` Liam Girdwood [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1291130139.3293.18.camel@odin \
    --to=lrg@slimlogic.co.uk \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox