Re: [PATCH v4] sched: automated per session task groups

Ingo Molnar
2010-11-29T12:31:06Z

* Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:

> On Sun, 2010-11-28 at 21:18 +0100, Ingo Molnar wrote:
> > * Linus Torvalds <torvalds@linux-foundation.org> wrote:
> >
> > > On Sun, Nov 28, 2010 at 6:24 AM, Mike Galbraith <efault@gmx.de> wrote:
> > > >
> > > > Something else is seriously wrong though. 36.1 with attached (plus
> > > > sched, cgroup: Fixup broken cgroup movement) works a treat, whereas
> > > > 37.git and tip with fixlet below both suck rocks. With a make -j40
> > > > running, wakeup-latency is showing latencies of >100ms, amarok skips,
> > > > mouse lurches badly.. generally horrid. Something went south.
> > >
> > > Can you test -rc3? Is that still ok? And are you perhaps using
> > > Nouveau? There's a report of some graphics (?) regression since -rc3
> > > about bad desktop performance:
> > >
> > > https://bugzilla.kernel.org/show_bug.cgi?id=23912
> > >
> > > but it doesn't have any more information yet (so if -rc3 _is_ good for
> > > you, and you can add anything to that report, it would be good. The
> > > original reporter is hopefully bisecting it now)
> >
> > Mike, the last pure -rc3 -tip commit is 92c883adf03b - you could try to check that
> > out too: it has most of the current sched/core commits, but has none of the post-rc3
> > DRM changes.
>

> Well we totally re-wrote the cgroup load-balancer in -tip. The thing currently in
> -linus is a utter crap because its very strongly serialized across all cores (some
> people spend like 25% of their time in there).

Yes, 92c883adf03b includes those changes:

08f3c3065f4c: Merge branch 'sched/core'
9437178f623a: sched: Update tg->shares after cpu.shares write
d6b5591829bd: sched: Allow update_cfs_load() to update global load
3b3d190ec368: sched: Implement demand based update_cfs_load()
c66eaf619c0c: sched: Update shares on idle_balance
a7a4f8a752ec: sched: Add sysctl_sched_shares_window
67e86250f8ea: sched: Introduce hierarchal order on shares update list
e33078baa4d3: sched: Fix update_cfs_load() synchronization
f0d7442a5924: sched: Fix load corruption from update_cfs_shares()
9e3081ca6114: sched: Make tg_shares_up() walk on-demand
3d4b47b4b040: sched: Implement on-demand (active) cfs_rq list
2069dd75c7d0: sched: Rewrite tg_shares_up)
48c5ccae88dc: sched: Simplify cpu-hot-unplug task migration
92fd4d4d67b9: Merge commit 'v2.6.37-rc2' into sched/core

I just wanted to give Mike a known-stable sha1 that has -rc3 but not the post-rc3
DRM changes.

Thanks,

Ingo