From: Dave Hansen <dave@linux.vnet.ibm.com>
To: Ike Panhc <ike.pan@canonical.com>
Cc: linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
Matthew Garrett <mjg@redhat.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 3/3] ideapad: add hotkey support
Date: Thu, 02 Dec 2010 15:41:27 -0800 [thread overview]
Message-ID: <1291333287.10586.4698.camel@nimitz> (raw)
In-Reply-To: <1289977238-15113-1-git-send-email-ike.pan@canonical.com>
On Wed, 2010-11-17 at 15:00 +0800, Ike Panhc wrote:
> +static void ideapad_input_report(unsigned long scancode)
> +{
> + sparse_keymap_report_event(ideapad_priv->inputdev, scancode, 1, true);
> +}
I got a little build error about some unresolved symbols in the module
while compiling:
ERROR: "sparse_keymap_setup" [drivers/platform/x86/ideapad-laptop.ko] undefined!
ERROR: "sparse_keymap_free" [drivers/platform/x86/ideapad-laptop.ko] undefined!
ERROR: "sparse_keymap_report_event" [drivers/platform/x86/ideapad-laptop.ko] undefined!
You can get it to go away by setting CONFIG_INPUT_SPARSEKMAP=m or =y
in .config. But, I think your patches need this:
diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index faec777..879d266 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -226,6 +226,7 @@ config IDEAPAD_LAPTOP
tristate "Lenovo IdeaPad Laptop Extras"
depends on ACPI
depends on RFKILL
+ select INPUT_SPARSEKMAP
help
This is a driver for the rfkill switches on Lenovo IdeaPad netbooks.
Signed-off-by: Dave Hansen <dave@linux.vnet.ibm.com>
next prev parent reply other threads:[~2010-12-02 23:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-17 6:59 [PATCH 0/3] ideapad: hotkey enablement Ike Panhc
2010-11-17 7:00 ` [PATCH 1/3] ideapad: add platform driver for ideapad Ike Panhc
2010-11-17 7:00 ` [PATCH 2/3] ideapad: let camera power control entry under platform driver Ike Panhc
2010-11-17 7:00 ` [PATCH 3/3] ideapad: add hotkey support Ike Panhc
2010-11-17 21:29 ` Dmitry Torokhov
2010-11-18 7:35 ` Corentin Chary
2010-11-19 7:09 ` Ike Panhc
2010-12-02 23:41 ` Dave Hansen [this message]
2010-12-02 23:43 ` Ike Panhc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291333287.10586.4698.camel@nimitz \
--to=dave@linux.vnet.ibm.com \
--cc=dwmw2@infradead.org \
--cc=ike.pan@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox