From: Namhyung Kim <namhyung@gmail.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Andreas Gruenbacher <agruen@suse.de>, linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] mbcache: remove unnecessary conditionals
Date: Tue, 7 Dec 2010 19:08:55 +0900 [thread overview]
Message-ID: <1291716536-10285-2-git-send-email-namhyung@gmail.com> (raw)
In-Reply-To: <1291716536-10285-1-git-send-email-namhyung@gmail.com>
The commit 2aec7c523291 ("mbcache: Remove unused features") removes
MB_CACHE_INDEXES_COUNT symbol so the test will be passed always.
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
---
fs/mbcache.c | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/fs/mbcache.c b/fs/mbcache.c
index 0477c71..c0cfc42 100644
--- a/fs/mbcache.c
+++ b/fs/mbcache.c
@@ -71,10 +71,8 @@ EXPORT_SYMBOL(mb_cache_entry_insert);
EXPORT_SYMBOL(mb_cache_entry_release);
EXPORT_SYMBOL(mb_cache_entry_free);
EXPORT_SYMBOL(mb_cache_entry_get);
-#if !defined(MB_CACHE_INDEXES_COUNT) || (MB_CACHE_INDEXES_COUNT > 0)
EXPORT_SYMBOL(mb_cache_entry_find_first);
EXPORT_SYMBOL(mb_cache_entry_find_next);
-#endif
struct mb_cache {
struct list_head c_cache_list;
@@ -500,8 +498,6 @@ cleanup:
return ce;
}
-#if !defined(MB_CACHE_INDEXES_COUNT) || (MB_CACHE_INDEXES_COUNT > 0)
-
static struct mb_cache_entry *
__mb_cache_entry_find(struct list_head *l, struct list_head *head,
struct block_device *bdev, unsigned int key)
@@ -604,8 +600,6 @@ mb_cache_entry_find_next(struct mb_cache_entry *prev,
return ce;
}
-#endif /* !defined(MB_CACHE_INDEXES_COUNT) || (MB_CACHE_INDEXES_COUNT > 0) */
-
static int __init init_mbcache(void)
{
register_shrinker(&mb_cache_shrinker);
--
1.7.0.4
next prev parent reply other threads:[~2010-12-07 10:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-07 10:08 [PATCH 1/3] mbcache: use list_for_each_entry* Namhyung Kim
2010-12-07 10:08 ` Namhyung Kim [this message]
2010-12-07 10:08 ` [PATCH 3/3] mbcache: update comments Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291716536-10285-2-git-send-email-namhyung@gmail.com \
--to=namhyung@gmail.com \
--cc=agruen@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox