Re: [PATCH 1/3] [SCSI] dpt_i2o: fix compiler warning on dptids

James Bottomley
2010-12-07T15:57:17Z

On Wed, 2010-12-08 at 00:31 +0900, Namhyung Kim wrote:
> Annotate dptids as '__used' to fix following warning:
>
> CC drivers/scsi/dpt_i2o.o
> drivers/scsi/dpt_i2o.c:183: warning: ‘dptids’ defined but not used
>
> Signed-off-by: Namhyung Kim <namhyung@gmail.com>
> Cc: Adaptec OEM Raid Solutions <aacraid@adaptec.com>
> ---
> drivers/scsi/dpt_i2o.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c
> index cffcb10..b276077 100644
> --- a/drivers/scsi/dpt_i2o.c
> +++ b/drivers/scsi/dpt_i2o.c
> @@ -180,7 +180,7 @@ static u8 adpt_read_blink_led(adpt_hba* host)
> *============================================================================
> */
>
> -static struct pci_device_id dptids[] = {
> +static struct pci_device_id dptids[] __used = {
> { PCI_DPT_VENDOR_ID, PCI_DPT_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID,},
> { PCI_DPT_VENDOR_ID, PCI_DPT_RAPTOR_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID,},
> { 0, }

Um so this is definitely used in the MODULE_DEVICE_TABLE just below.

I deduce you have some type of config which causes that to be a nop
(say !CONFIG_MODULE)? In which case, surely the correct fix is in
module.h?

James