Re: [PATCH 1/3] [SCSI] dpt_i2o: fix compiler warning on dptids

Namhyung Kim
2010-12-07T16:12:38Z

2010-12-07 (화), 09:57 -0600, James Bottomley:
> Um so this is definitely used in the MODULE_DEVICE_TABLE just below.
>
> I deduce you have some type of config which causes that to be a nop
> (say !CONFIG_MODULE)? In which case, surely the correct fix is in
> module.h?
>

Hi,

MODULE_DEVICE_TABLE expands to nop when !MODULE (not !CONFIG_MODULE) so
allyesconfig build always emits the warnings. Possible patch for this
would be wraping it up in #ifdefs but when I sent a same patch to Greg
KH he didn't want to add more #ifdefs in .c files.

--
Regards,
Namhyung Kim