Re: perf hw in kexeced kernel broken in tip

Don Zickus
2010-12-09T04:35:22Z

On Wed, Dec 08, 2010 at 03:20:37PM -0800, Eric W. Biederman wrote:
> Don Zickus <dzickus@redhat.com> writes:
>
> > On Wed, Dec 08, 2010 at 03:59:16PM +0100, Peter Zijlstra wrote:
> >> On Wed, 2010-12-08 at 15:20 +0100, Peter Zijlstra wrote:
> >>
> >> > > I wonder if you should reverse these checks. If the bios has the perf
> >> > > counter enabled, there might be a high chance that it fails the first
> >> > > check and never gets to the actually bios checks.
> >> >
> >> > Ah, good point.
> >>
> >> Something like so..
> >
> > This seems to work correctly on my Nehalem and broken bios machines during
> > boot and kexec. As expected it fails during kdump. My p4 box failed
> > during kexec for some reason. But p4 has other issues.
>
> Does the kdump kernel still boot?
>
> It looks like it should I just want to double check.

Yeah, sorry for not being clear. It definitely boots and does it thing.
perf init (and thus nmi watchdog) fail with 'BIOS broken' because the perf
counters were not shutdown prior to executing kdump.

Cheers,
Don