* [PATCH] LEDs: fix check for return value of blink_set callback
@ 2010-12-10 9:58 Vasily Khoruzhick
2010-12-10 14:43 ` Richard Purdie
0 siblings, 1 reply; 2+ messages in thread
From: Vasily Khoruzhick @ 2010-12-10 9:58 UTC (permalink / raw)
To: linux-kernel, Richard Purdie; +Cc: Vasily Khoruzhick
blink_set callback should return 0 on success, but check in
led-class.c is invalid. It results in software fallback even if
hw support is available.
Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
---
drivers/leds/led-class.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c
index 211e21f..d5a4ade 100644
--- a/drivers/leds/led-class.c
+++ b/drivers/leds/led-class.c
@@ -267,7 +267,7 @@ void led_blink_set(struct led_classdev *led_cdev,
unsigned long *delay_off)
{
if (led_cdev->blink_set &&
- led_cdev->blink_set(led_cdev, delay_on, delay_off))
+ !led_cdev->blink_set(led_cdev, delay_on, delay_off))
return;
/* blink with 1 Hz as default if nothing specified */
--
1.7.3.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] LEDs: fix check for return value of blink_set callback
2010-12-10 9:58 [PATCH] LEDs: fix check for return value of blink_set callback Vasily Khoruzhick
@ 2010-12-10 14:43 ` Richard Purdie
0 siblings, 0 replies; 2+ messages in thread
From: Richard Purdie @ 2010-12-10 14:43 UTC (permalink / raw)
To: Vasily Khoruzhick, akpm; +Cc: linux-kernel
On Fri, 2010-12-10 at 11:58 +0200, Vasily Khoruzhick wrote:
> blink_set callback should return 0 on success, but check in
> led-class.c is invalid. It results in software fallback even if
> hw support is available.
>
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
Acked-by: Richard Purdie <rpurdie@linux.intel.com>
> ---
> drivers/leds/led-class.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/leds/led-class.c b/drivers/leds/led-class.c
> index 211e21f..d5a4ade 100644
> --- a/drivers/leds/led-class.c
> +++ b/drivers/leds/led-class.c
> @@ -267,7 +267,7 @@ void led_blink_set(struct led_classdev *led_cdev,
> unsigned long *delay_off)
> {
> if (led_cdev->blink_set &&
> - led_cdev->blink_set(led_cdev, delay_on, delay_off))
> + !led_cdev->blink_set(led_cdev, delay_on, delay_off))
> return;
>
> /* blink with 1 Hz as default if nothing specified */
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-12-10 14:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-12-10 9:58 [PATCH] LEDs: fix check for return value of blink_set callback Vasily Khoruzhick
2010-12-10 14:43 ` Richard Purdie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox