Re: [PATCH v4] mach-at91: Support for gsia18s board added

Russell King - ARM Linux
2010-12-12T14:22:15Z

On Sun, Dec 12, 2010 at 03:07:27PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 09:37 Sun 12 Dec , Igor Plyatov wrote:
> > Dear Jean-Christophe,
> >
> > > On 20:00 Fri 10 Dec , Igor Plyatov wrote:
> > > > +/*
> > > > + * Up to date linux/arch/arm/tools/mach-types database required to support this.

Please wrap comments.

> > > > +MACHINE_START(GSIA18S, "GS_IA18_S")
> > > > +*/
> > > > +MACHINE_START(STAMP9G20, "GS_IA18_S")
> > > if you do this you must use system_rev to identify the board
> >
> > I can cite Christian Glindkamp:
> > "And for different carrier boards, system_rev does not make sense at
> > all."
> >
> > Please, use more testimony why it is required to use system_rev here.
> > Yours position does not clear for me.
> > You can point me to the right documentation or discussion about this
> > requirements in the mail archives...
>
> two bards with the same machine id NACK as we can not compile them in the same
> kernel and this a target we all work on to allow
> if you want to tuse the same machine id as I did for other boards you must use
> system_rev or any detection to identify tehm

Well, the platform was registered into the machine database on 10th
December, so it's missed my recent update to the file queued for the next
-rc.

I also notice that the name has been changed - machine_is_gsia18s() vs
MACH_TYPE_GS_IA18_S / CONFIG_MACH_GS_IA18_S. This means I'll simply
delete it from any future updates until someone talks to me about fixing
the entry, exactly as I'm doing with a bunch of others who also haven't
contacted me.

All it takes is an email and the entry gets quickly fixed...