From: Namhyung Kim <namhyung@gmail.com>
To: Greg Kroah-Hartman <gregkh@suse.de>, Martyn Welch <martyn.welch@ge.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH 4/8] Staging: vme_ca91cx42: remove unreachable code
Date: Mon, 13 Dec 2010 22:16:32 +0900 [thread overview]
Message-ID: <1292246196-2332-4-git-send-email-namhyung@gmail.com> (raw)
In-Reply-To: <1292246196-2332-1-git-send-email-namhyung@gmail.com>
The iounmap() call and a assignment are could not be executed
because they have no label. Remove them and merge short lines.
Signed-off-by: Namhyung Kim <namhyung@gmail.com>
---
drivers/staging/vme/bridges/vme_ca91cx42.c | 5 +----
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/vme/bridges/vme_ca91cx42.c b/drivers/staging/vme/bridges/vme_ca91cx42.c
index a9ce1810bd94..1052a6d101cd 100644
--- a/drivers/staging/vme/bridges/vme_ca91cx42.c
+++ b/drivers/staging/vme/bridges/vme_ca91cx42.c
@@ -551,8 +551,7 @@ static int ca91cx42_alloc_resource(struct vme_master_resource *image,
goto err_resource;
}
- image->kern_base = ioremap_nocache(
- image->bus_resource.start, size);
+ image->kern_base = ioremap_nocache(image->bus_resource.start, size);
if (image->kern_base == NULL) {
dev_err(ca91cx42_bridge->parent, "Failed to remap resource\n");
retval = -ENOMEM;
@@ -561,8 +560,6 @@ static int ca91cx42_alloc_resource(struct vme_master_resource *image,
return 0;
- iounmap(image->kern_base);
- image->kern_base = NULL;
err_remap:
release_resource(&(image->bus_resource));
err_resource:
--
1.7.3.3.400.g93cef
next prev parent reply other threads:[~2010-12-13 13:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-13 13:16 [PATCH 1/8] Staging: vme_ca91cx42: fix compiler warning on 64-bit build Namhyung Kim
2010-12-13 13:16 ` [PATCH 2/8] Staging: vme_bridge: mark vme_master_resource->kern_base as __iomem Namhyung Kim
2010-12-13 18:36 ` Greg KH
2010-12-14 4:52 ` Namhyung Kim
2010-12-14 9:15 ` Martyn Welch
2010-12-13 13:16 ` [PATCH 3/8] Staging: vme_ca91cx42: mark ca91cx42_driver->base " Namhyung Kim
2010-12-13 13:16 ` Namhyung Kim [this message]
2010-12-13 13:16 ` [PATCH 5/8] Staging: vme_ca91cx42: make functions static Namhyung Kim
2010-12-13 13:16 ` [PATCH 6/8] Staging: vme_tsi148: mark tsi148_driver->base as __iomem Namhyung Kim
2010-12-13 13:16 ` [PATCH 7/8] Staging: vme_tsi148: remove unreachable code Namhyung Kim
2010-12-13 13:16 ` [PATCH 8/8] Staging: vme_tsi148: make functions static Namhyung Kim
2010-12-13 13:50 ` [PATCH 1/8] Staging: vme_ca91cx42: fix compiler warning on 64-bit build Jiri Slaby
2010-12-13 14:16 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292246196-2332-4-git-send-email-namhyung@gmail.com \
--to=namhyung@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=martyn.welch@ge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox