From: Liam Girdwood <lrg@slimlogic.co.uk>
To: Takashi Iwai <tiwai@suse.de>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>,
Tejun Heo <tj@kernel.org>,
linux-kernel@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>
Subject: Re: [PATCH 09/30] sound: don't use flush_scheduled_work()
Date: Mon, 13 Dec 2010 13:29:03 +0000 [thread overview]
Message-ID: <1292246943.3320.59.camel@odin> (raw)
In-Reply-To: <s5h7hfe5aw2.wl%tiwai@suse.de>
On Mon, 2010-12-13 at 09:34 +0100, Takashi Iwai wrote:
> At Sun, 12 Dec 2010 12:40:41 +0000,
> Mark Brown wrote:
> >
> > On Sun, Dec 12, 2010 at 01:38:36PM +0100, Takashi Iwai wrote:
> >
> > > Meanwhile, I wondered whether it's the really wanted behavior for
> > > that particular code path, thus the previous question to Liam.
> >
> > Yes, it's desired behaviour. That's what the old code was trying to do.
>
> OK, now I merged to sound git tree.
> Also it's merged back to topic/asoc branch with a conflict fix.
> Please pull appropriately.
>
> (I still don't remember why it had to be flush_work_sync() instead
> of cancel_work_sync() in the remove callback path for ASoC, though...
> Both aren't so much different nowadays and should work fine in such a
> case, though :)
Fwiw, I can't remember either why it had to be flush_work_sync() here.
The initial soc-core stuff was 5 years ago and the reason is well and
truly forgotten ;-)
Thanks
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
next prev parent reply other threads:[~2010-12-13 13:29 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1292086307-19211-1-git-send-email-tj@kernel.org>
[not found] ` <1292086307-19211-8-git-send-email-tj@kernel.org>
2010-12-11 21:33 ` [PATCH 07/30] ocfs2: don't use flush_scheduled_work() Joel Becker
[not found] ` <1292086307-19211-10-git-send-email-tj@kernel.org>
2010-12-12 8:56 ` [PATCH 09/30] sound: " Takashi Iwai
2010-12-12 9:15 ` Tejun Heo
2010-12-12 12:38 ` Takashi Iwai
2010-12-12 12:40 ` Mark Brown
2010-12-12 16:02 ` Tejun Heo
2010-12-12 18:47 ` Mark Brown
2010-12-12 18:50 ` Tejun Heo
2010-12-12 19:00 ` Mark Brown
2010-12-13 13:32 ` Liam Girdwood
2010-12-13 16:36 ` Olaya, Margarita
2010-12-13 8:34 ` Takashi Iwai
2010-12-13 13:29 ` Liam Girdwood [this message]
2010-12-13 16:12 ` Mark Brown
[not found] ` <1292086307-19211-21-git-send-email-tj@kernel.org>
[not found] ` <20101211201931.00414518@endymion.delvare>
2010-12-12 13:37 ` [PATCH 20/30] macintosh/ams: " Michael Hanselmann
2010-12-13 10:16 ` Stelian Pop
2010-12-13 10:18 ` Jean Delvare
2010-12-13 10:40 ` [PATCH] Remove myself from MAINTAINERS as I no longer have the hardware to test Stelian Pop
2010-12-16 9:58 ` Jean Delvare
[not found] ` <1292086307-19211-22-git-send-email-tj@kernel.org>
2010-12-13 8:44 ` [PATCH 21/30] pcmcia/ipwireless: don't use flush_scheduled_work() David Sterba
[not found] ` <1292086307-19211-6-git-send-email-tj@kernel.org>
2010-12-13 11:21 ` [PATCH 05/30] net/dsa: " Lennert Buytenhek
[not found] ` <1292086307-19211-28-git-send-email-tj@kernel.org>
2010-12-14 16:53 ` [PATCH 27/30] mtd: " Artem Bityutskiy
[not found] ` <1292086307-19211-29-git-send-email-tj@kernel.org>
2010-12-22 0:07 ` [PATCH 28/30] battery: " Anton Vorontsov
2010-12-24 15:02 ` [PATCHSET] workqueue: remove flush_scheduled_work() usage Tejun Heo
[not found] ` <1292086307-19211-2-git-send-email-tj@kernel.org>
2010-12-15 18:33 ` [PATCH 01/30] infiniband: update workqueue usage Roland Dreier
2010-12-16 16:50 ` Tejun Heo
2010-12-23 21:47 ` David Dillow
2011-01-17 5:21 ` Roland Dreier
2011-01-24 11:06 ` [PATCH] RDMA: update missed converion of flush_scheduled_work() Tejun Heo
2011-01-24 11:12 ` [PATCH RFC] RDMA: use alloc[_ordered]_workqueue() Tejun Heo
2011-01-29 0:40 ` [PATCH] RDMA: update missed converion of flush_scheduled_work() Roland Dreier
2011-01-31 10:36 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292246943.3320.59.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox