From: Namhyung Kim <namhyung@gmail.com>
To: Greg KH <greg@kroah.com>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
Martyn Welch <martyn.welch@ge.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Staging: vme_ca91cx42: use __dev{init,exit} for ->probe/remove
Date: Tue, 14 Dec 2010 13:43:19 +0900 [thread overview]
Message-ID: <1292301799.1696.22.camel@leonhard> (raw)
In-Reply-To: <20101213182656.GA4645@kroah.com>
2010-12-13 (월), 10:26 -0800, Greg KH:
> On Sun, Dec 12, 2010 at 05:04:27PM +0900, Namhyung Kim wrote:
> > Signed-off-by: Namhyung Kim <namhyung@gmail.com>
> > ---
> > drivers/staging/vme/bridges/vme_ca91cx42.c | 12 +++++++-----
>
> This patch does not apply to the linux-next tree, what did you generate
> it against?
>
Argh.. sorry, it was Linus's tree. Will resend if you want.
> Also, why are you marking these functions, is it really needed? Same
> thing for your 2/2 patch.
>
?? Maybe I don't get what you mean exactly.. They are hotplugging
stuffs, right? So shouldn't they be marked as such?
--
Regards,
Namhyung Kim
prev parent reply other threads:[~2010-12-14 4:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-12 8:04 [PATCH 1/2] Staging: vme_ca91cx42: use __dev{init,exit} for ->probe/remove Namhyung Kim
2010-12-12 8:04 ` [PATCH 2/2] Staging: vme_tsi148: " Namhyung Kim
2010-12-13 18:26 ` [PATCH 1/2] Staging: vme_ca91cx42: " Greg KH
2010-12-14 4:43 ` Namhyung Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292301799.1696.22.camel@leonhard \
--to=namhyung@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=martyn.welch@ge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox