Re: [PATCH] cramfs: generate unique inode number for better inode cache usage

Stefani Seibold
2010-12-16T09:46:33Z

Am Mittwoch, den 15.12.2010, 08:45 -0800 schrieb Linus Torvalds:
> On Wed, Dec 15, 2010 at 8:31 AM, <stefani@seibold.net> wrote:
> >
> > Pekka's approach is not problem. But the "cruddy" CRAMINO_UNIQ() is exact
> > what is needed. In your orginal design of cramfs there is no way to give
> > entries with no data an unique inode number.
>
> Umm. And my cramino() did exactly that. If it has a data pointer, it
> uses that, otherwise it uses the directory offset.
>

The current implementation does it not.

> It just doesn't care about the mode of the file.
>

Right, but there are a buggy cramfs tools (which can create images for
different endian target or create on the fly devices nodes and so on)
out there, which set the offset of the cramfs_inode to a value not equal
0. This works well with older kernel like 2.6.12 but during the
evolution of the kernel this was broken.

I will resend a cleaned up patch. Hope you will apply it ;-)

Stefani