Re: [PATCH] cramfs: generate unique inode number for better inode cache usage

Linus Torvalds
2010-12-15T15:52:18Z

On Wed, Dec 15, 2010 at 12:15 AM, Pekka Enberg <penberg@kernel.org> wrote:
>
> I think Linus is after something like this:

That works for me, but I hate the double "switch()" statement checking
the same thing.

Why is the camino() function not just doing something like

static unsigned int cramino(struct cramfs_inode *ino, unsigned int
dirent_offset)
{
unsigned int data_offset = ino->offset;
return data_offset ? data_offset << 2 : dirent_offset+1;
}

and we can get rid of all the cruddy CRAMINO_UNIQ() and testing of the
mode entirely for that path.

That, together with Pekka's approach seems nice, simple and clean.

Linus