Re: [PATCH 1/7] msm: io: I/O register definitions for MSM8960

Arnd Bergmann
2010-12-15T16:40:40Z

On Wednesday 15 December 2010, David Brown wrote:
>
> On Wed, Dec 15, 2010 at 04:31:11PM +0100, Arnd Bergmann wrote:
> > On Wednesday 15 December 2010, Stepan Moskovchenko wrote:
>
> > In this particular case, it's rather confusing, because one would assume
> > that MSM8960 is a subset of MSM8X60!
>
> Unfortunately, this is not the case, and I'm not sure what better name
> to use for MSM8X60. The MSM8X60 name covers MSM8260 and MSM8660, but
> MSM8960 is quite a bit different. Any ideas for better names?

No, you probably lose there, unless you can fall back to code names
instead of product numbers.

My point was really that they should not be exclusive, even if they
are rather different. If the code is structured in a more modular
way, you can turn all MSM/QSD options from the "Qualcomm MSM SoC Type"
choice into separate "bool" config options. You probably don't want
to do that now for all the existing ones, but I would suggest you
try not add more to the pile ;-).

Arnd