Re: [PATCH v2 07/11] msm: Add MSM 8960 cpu_is check

David Brown
2011-01-24T21:30:57Z

On Mon, Jan 24 2011, Daniel Walker wrote:

> On Wed, 2011-01-19 at 12:25 -0800, David Brown wrote:
>> diff --git a/arch/arm/mach-msm/include/mach/cpu.h
>> b/arch/arm/mach-msm/include/mach/cpu.h
>> index e1ba9db..a9481b0 100644
>> --- a/arch/arm/mach-msm/include/mach/cpu.h
>> +++ b/arch/arm/mach-msm/include/mach/cpu.h
>> @@ -24,6 +24,7 @@
>> #define cpu_is_msm7x30() 0
>> #define cpu_is_qsd8x50() 0
>> #define cpu_is_msm8x60() 0
>> +#define cpu_is_msm8960() 0
>
> The naming is just perverted even more here..

What do you want me to call it?

#define cpu_is_97d0c886-3768-4998-8925-16f36209d0d1()

It's the name of the chip. We've already been through this. The names
are unfortunate, but it is what the devices are called.

At some point, I may change the msm8x60 to something more specific, such
as msm8260, or msm8660, one of the devices that it represents. But this
isn't correct, either. There really isn't a good answer.

David