public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: linux-kernel@vger.kernel.org, jaxboe@fusionio.com,
	paulmck@linux.vnet.ibm.com
Cc: vgoyal@redhat.com, oleg@redhat.com
Subject: [PATCH 1/2] blk-throttle: process limit change only through one function
Date: Wed, 15 Dec 2010 16:07:34 -0500	[thread overview]
Message-ID: <1292447255-10698-2-git-send-email-vgoyal@redhat.com> (raw)
In-Reply-To: <1292447255-10698-1-git-send-email-vgoyal@redhat.com>

o With the help of cgroup interface one can go and upate the bps/iops limits
  of existing group. Once the limits are udpated, a thread is woken up to
  see if some blocked group needs recalculation based on new limits and needs
  to be requeued.

o There was also a piece of code where I was checking for group limit update
  when a fresh bio comes in. This patch gets rid of that piece of code and
  keeps processing the limit change at one place throtl_process_limit_change().
  It just keeps the code simple and easy to understand.

Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
---
 block/blk-throttle.c |    8 +-------
 1 files changed, 1 insertions(+), 7 deletions(-)

diff --git a/block/blk-throttle.c b/block/blk-throttle.c
index 381b09b..91bd444 100644
--- a/block/blk-throttle.c
+++ b/block/blk-throttle.c
@@ -998,14 +998,8 @@ int blk_throtl_bio(struct request_queue *q, struct bio **biop)
 		/*
 		 * There is already another bio queued in same dir. No
 		 * need to update dispatch time.
-		 * Still update the disptime if rate limits on this group
-		 * were changed.
 		 */
-		if (!tg->limits_changed)
-			update_disptime = false;
-		else
-			tg->limits_changed = false;
-
+		update_disptime = false;
 		goto queue_bio;
 	}
 
-- 
1.7.1


  reply	other threads:[~2010-12-15 21:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-15 21:07 [PATCH 0/2] blk-throttle: Couple of more fixes Vivek Goyal
2010-12-15 21:07 ` Vivek Goyal [this message]
2010-12-15 21:07 ` [PATCH 2/2] blk-throttle: Some cleanups and race fixes in limit update code Vivek Goyal
2010-12-16 14:49   ` Oleg Nesterov
2010-12-17 22:28   ` Paul E. McKenney
2010-12-17 22:34     ` Vivek Goyal
2011-03-29 23:14   ` [PATCH] blk-throttle: don't call xchg on bool Andreas Schwab
2011-03-30 10:21     ` Jens Axboe
2011-03-30 13:19     ` Vivek Goyal
2011-03-30 13:51       ` Andreas Schwab
2011-03-30 16:53         ` Vivek Goyal
2011-03-30 16:06       ` Andreas Schwab
2010-12-21 16:05 ` [PATCH 0/2] blk-throttle: Couple of more fixes Vivek Goyal
  -- strict thread matches above, loose matches on Subject: below --
2011-02-21 23:42 [PATCH 0/2] blk-throttle: Couple of cleanup and fixes for limit update code Vivek Goyal
2011-02-21 23:42 ` [PATCH 1/2] blk-throttle: process limit change only through one function Vivek Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1292447255-10698-2-git-send-email-vgoyal@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=jaxboe@fusionio.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=paulmck@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox