Re: [PATCH -mm -v8 0/3] Lockless memory allocator and list

Peter Zijlstra
2010-12-17T12:23:01Z

On Fri, 2010-12-17 at 08:20 +0800, Huang Ying wrote:
> On Thu, 2010-12-16 at 17:24 +0800, Peter Zijlstra wrote:
> > On Thu, 2010-12-16 at 14:59 +0800, Huang Ying wrote:
> > > This patchset adds a lockless memory allocator and a lock-less
> > > list.
> >
> > Still no users the allocator, and no attempt to unify the existing
> > lockless list implementations.
> >
> > I'm getting very tired of this Huang.
>
> I just want to do that in the next step after merging the data structure
> itself. The first user of the allocator is APEI, which will go ACPI
> tree, lockless list in irq_work will go tip tree, lockless list in xlist
> will go net tree.
>
> We must merge the data structure with its users together?

Yes -- that's how new infrastructure gets merged. Because if we don't
agree with the users (I don't) there is no point in merging these things
either.

I would really like you to stop posting code and talk to the EDAC guys.
You just keep on posting the same crap over and over again without
making any kind of progress what so ever.

So stop pushing your crap, _please_, and talk to the EDAC and other RAS
guys and come up with something together.

I haven't heard a single other RAS guy agree with your approach, and I'm
getting really sick of you just pushing your stuff without even wanting
to talk to them.

I don't want to see a single line of code from you until you've talked
with other RAS folks and they agree that your bits make sense.

So let me put it in simple words: unless there's a non-Intel RAS guy
signing off on your patches I'm objecting to them.

The thing is, a unified RAS infrastructure is much more useful for
admins, it means they can use the same tools regardless of what platform
they're running on.

Now I know creating such a thing seems daunting, but at least give it a
try, its better to have tried and failed that not attempted at all, at
worst you'll learn what you did wrong and can try to do better the
second time around.