From: Robert Morell <rmorell@nvidia.com>
To: David Brownell <dbrownell@users.sourceforge.net>,
Greg Kroah-Hartman <gregkh@suse.de>,
Benoit Goby <benoit@android.com>,
Alan Stern <stern@rowland.harvard.edu>,
Sarah Sharp <sarah.a.sharp@linux.intel.com>,
Matthew Wilcox <willy@linux.intel.com>,
Ming Lei <tom.leiming@gmail.com>,
Jacob Pan <jacob.jun.pan@intel.com>
Cc: Olof Johansson <olof@lixom.net>,
Erik Gilling <konkers@android.com>,
Colin Cross <ccross@android.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-tegra@vger.kernel.org, Robert Morell <rmorell@nvidia.com>
Subject: [PATCH v2 1/2] USB: Add driver hooks for (un)?map_urb_for_dma
Date: Fri, 17 Dec 2010 17:49:30 -0800 [thread overview]
Message-ID: <1292636971-17701-2-git-send-email-rmorell@nvidia.com> (raw)
In-Reply-To: <1292623129-26361-1-git-send-email-rmorell@nvidia.com>
These are useful in case your device has quirks involving what memory
is and is not DMAable.
Signed-off-by: Robert Morell <rmorell@nvidia.com>
Reviewed-by: Scott Williams <scwilliams@nvidia.com>
Reviewed-by: Janne Hellsten <jhellsten@nvidia.com>
---
drivers/usb/core/hcd.c | 19 ++++++++++++++++++-
include/linux/usb/hcd.h | 8 ++++++++
2 files changed, 26 insertions(+), 1 deletions(-)
diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index 5cca00a..84fee0f 100644
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hcd.c
@@ -1265,6 +1265,14 @@ static void hcd_free_coherent(struct usb_bus *bus, dma_addr_t *dma_handle,
static void unmap_urb_for_dma(struct usb_hcd *hcd, struct urb *urb)
{
+ if (hcd->driver->unmap_urb_for_dma)
+ hcd->driver->unmap_urb_for_dma(hcd, urb);
+ else
+ usb_hcd_unmap_urb_for_dma(hcd, urb);
+}
+
+void usb_hcd_unmap_urb_for_dma(struct usb_hcd *hcd, struct urb *urb)
+{
enum dma_data_direction dir;
if (urb->transfer_flags & URB_SETUP_MAP_SINGLE)
@@ -1311,6 +1319,15 @@ static void unmap_urb_for_dma(struct usb_hcd *hcd, struct urb *urb)
static int map_urb_for_dma(struct usb_hcd *hcd, struct urb *urb,
gfp_t mem_flags)
{
+ if (hcd->driver->map_urb_for_dma)
+ return hcd->driver->map_urb_for_dma(hcd, urb, mem_flags);
+ else
+ return usb_hcd_map_urb_for_dma(hcd, urb, mem_flags);
+}
+
+int usb_hcd_map_urb_for_dma(struct usb_hcd *hcd, struct urb *urb,
+ gfp_t mem_flags)
+{
enum dma_data_direction dir;
int ret = 0;
@@ -1400,7 +1417,7 @@ static int map_urb_for_dma(struct usb_hcd *hcd, struct urb *urb,
}
if (ret && (urb->transfer_flags & (URB_SETUP_MAP_SINGLE |
URB_SETUP_MAP_LOCAL)))
- unmap_urb_for_dma(hcd, urb);
+ usb_hcd_unmap_urb_for_dma(hcd, urb);
}
return ret;
}
diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h
index 3b571f1..8aaf687 100644
--- a/include/linux/usb/hcd.h
+++ b/include/linux/usb/hcd.h
@@ -233,6 +233,11 @@ struct hc_driver {
int (*urb_dequeue)(struct usb_hcd *hcd,
struct urb *urb, int status);
+ /* dma support */
+ int (*map_urb_for_dma)(struct usb_hcd *hcd, struct urb *urb,
+ gfp_t mem_flags);
+ void (*unmap_urb_for_dma)(struct usb_hcd *hcd, struct urb *urb);
+
/* hw synch, freeing endpoint resources that urb_dequeue can't */
void (*endpoint_disable)(struct usb_hcd *hcd,
struct usb_host_endpoint *ep);
@@ -327,6 +332,9 @@ extern void usb_hcd_unlink_urb_from_ep(struct usb_hcd *hcd, struct urb *urb);
extern int usb_hcd_submit_urb(struct urb *urb, gfp_t mem_flags);
extern int usb_hcd_unlink_urb(struct urb *urb, int status);
+extern int usb_hcd_map_urb_for_dma(struct usb_hcd *hcd, struct urb *urb,
+ gfp_t mem_flags);
+extern void usb_hcd_unmap_urb_for_dma(struct usb_hcd *hcd, struct urb *urb);
extern void usb_hcd_giveback_urb(struct usb_hcd *hcd, struct urb *urb,
int status);
extern void usb_hcd_flush_endpoint(struct usb_device *udev,
--
1.7.2.2
next prev parent reply other threads:[~2010-12-18 1:50 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-17 21:58 [RFC] Align tegra-ehci DMA transfers to 32B Robert Morell
2010-12-17 21:58 ` [PATCH 1/2] USB: Add driver hooks for (un)?map_urb_for_dma Robert Morell
2010-12-17 21:58 ` [PATCH 2/2] USB: ehci: tegra: Align DMA transfers to 32 bytes Robert Morell
2010-12-17 22:35 ` Greg KH
2010-12-17 22:42 ` rmorell
2010-12-17 23:09 ` Greg KH
2010-12-17 23:17 ` Oliver Neukum
2010-12-17 23:35 ` Greg KH
2010-12-17 23:50 ` rmorell
2010-12-17 23:40 ` rmorell
2010-12-18 0:37 ` Greg KH
2010-12-18 1:29 ` rmorell
2010-12-17 22:32 ` [RFC] Align tegra-ehci DMA transfers to 32B Greg KH
2010-12-17 22:44 ` rmorell
2010-12-17 23:07 ` Greg KH
2010-12-17 23:07 ` David Brownell
2010-12-18 1:49 ` [PATCH v2] " Robert Morell
2010-12-19 21:38 ` [PATCH] " Robert Morell
2011-01-06 23:20 ` [PATCH v4] " Robert Morell
2011-01-20 21:41 ` [PATCH v5] " Robert Morell
2011-01-27 3:06 ` [PATCH v6] " Robert Morell
2011-01-27 3:06 ` [PATCH 1/3] USB: HCD: Add usb_hcd prefix to exported functions Robert Morell
2011-01-27 16:01 ` Alan Stern
2011-01-27 3:06 ` [PATCH 2/3] USB: HCD: Add driver hooks for (un)?map_urb_for_dma Robert Morell
2011-01-27 16:01 ` Alan Stern
2011-01-27 3:06 ` [PATCH 3/3] USB: ehci: tegra: Align DMA transfers to 32 bytes Robert Morell
2011-02-04 19:49 ` Greg KH
2011-02-04 20:14 ` Olof Johansson
2011-02-04 20:16 ` Greg KH
2011-02-04 20:26 ` rmorell
2011-02-04 20:35 ` Greg KH
2011-01-20 21:41 ` [PATCH 1/2] USB: HCD: Add driver hooks for (un)?map_urb_for_dma Robert Morell
2011-01-23 3:46 ` Greg KH
2011-01-24 16:32 ` Alan Stern
2011-01-20 21:41 ` [PATCH 2/2] USB: ehci: tegra: Align DMA transfers to 32 bytes Robert Morell
2011-01-24 16:36 ` Alan Stern
2011-01-24 22:53 ` rmorell
2011-01-25 2:59 ` Alan Stern
2011-01-06 23:20 ` [PATCH v4 1/2] USB: HCD: Add driver hooks for (un)?map_urb_for_dma Robert Morell
2011-01-06 23:20 ` [PATCH v4 2/2] USB: ehci: tegra: Align DMA transfers to 32 bytes Robert Morell
2010-12-19 21:38 ` [PATCH 1/2] USB: Add driver hooks for (un)?map_urb_for_dma Robert Morell
2010-12-19 21:38 ` [PATCH 2/2] USB: ehci: tegra: Align DMA transfers to 32 bytes Robert Morell
2010-12-19 21:57 ` Oliver Neukum
2010-12-18 1:49 ` Robert Morell [this message]
2010-12-18 17:51 ` [PATCH v2 1/2] USB: Add driver hooks for (un)?map_urb_for_dma Greg KH
2010-12-18 1:49 ` [PATCH v2 2/2] USB: ehci: tegra: Align DMA transfers to 32 bytes Robert Morell
2010-12-18 17:52 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292636971-17701-2-git-send-email-rmorell@nvidia.com \
--to=rmorell@nvidia.com \
--cc=benoit@android.com \
--cc=ccross@android.com \
--cc=dbrownell@users.sourceforge.net \
--cc=gregkh@suse.de \
--cc=jacob.jun.pan@intel.com \
--cc=konkers@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=olof@lixom.net \
--cc=sarah.a.sharp@linux.intel.com \
--cc=stern@rowland.harvard.edu \
--cc=tom.leiming@gmail.com \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox