Re: [PATCH] MTD: m25p80: add debugging trace in sst_write()

Russell King - ARM Linux
2010-12-15T16:13:10Z

On Wed, Dec 15, 2010 at 04:25:28PM +0300, Sergei Shtylyov wrote:
>> + DEBUG(MTD_DEBUG_LEVEL2, "%s: %s %s 0x%08x, len %zd\n",
>> + dev_name(&flash->spi->dev), __func__, "to",
>
> What's the point of printing "to" as variable? :-)

One valid reason to do this is if you have several formatting strings
all the same. GCC can merge identical strings together.

So, if you have:

"%s: %s %s 0x%08x, len %zd", dev_name(), __func__, "to"
"%s: %s %s 0x%08x, len %zd", dev_name(), __func__, "from"
"%s: %s %s 0x%08x, len %zd", dev_name(), __func__, "foo"

Then you end up with one long string and three short strings instead of

"%s: %s to 0x%08x, len %zd", dev_name(), __func__
"%s: %s from 0x%08x, len %zd", dev_name(), __func__
"%s: %s foo 0x%08x, len %zd", dev_name(), __func__

which'd be three long strings.