From: Liam Girdwood <lrg@slimlogic.co.uk>
To: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: linux-kernel@vger.kernel.org,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Axel Lin <axel.lin@gmail.com>,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH 1/2] regulator: max8952 - fix max8952_set_voltage check condition.
Date: Tue, 21 Dec 2010 12:58:32 +0000 [thread overview]
Message-ID: <1292936312.3296.8.camel@odin> (raw)
In-Reply-To: <1292907880-3353-1-git-send-email-myungjoo.ham@samsung.com>
On Tue, 2010-12-21 at 14:04 +0900, MyungJoo Ham wrote:
> In the current implementation, the GPIO pin, vid0 is checked twice
> (duplicated!) while vid1 is never checked; however, both vid0 and
> vid1 should be checked. This patch fixes the typo that stated vid0 where
> should've stated vid1.
>
> Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> drivers/regulator/max8952.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/regulator/max8952.c b/drivers/regulator/max8952.c
> index 0d5dda4..c7dae2b 100644
> --- a/drivers/regulator/max8952.c
> +++ b/drivers/regulator/max8952.c
> @@ -139,7 +139,7 @@ static int max8952_set_voltage(struct regulator_dev *rdev,
> s8 vid = -1, i;
>
> if (!gpio_is_valid(max8952->pdata->gpio_vid0) ||
> - !gpio_is_valid(max8952->pdata->gpio_vid0)) {
> + !gpio_is_valid(max8952->pdata->gpio_vid1)) {
> /* DVS not supported */
> return -EPERM;
> }
Does this series depend on your MFD MAX8998/LP3974 hibernation, charger
patch ?
Thanks
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
prev parent reply other threads:[~2010-12-21 12:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-21 5:04 [PATCH 1/2] regulator: max8952 - fix max8952_set_voltage check condition MyungJoo Ham
2010-12-21 5:04 ` [PATCH 2/2] regulator: max8952 - support hibernation MyungJoo Ham
2010-12-21 11:32 ` Mark Brown
2010-12-21 11:30 ` [PATCH 1/2] regulator: max8952 - fix max8952_set_voltage check condition Mark Brown
2010-12-21 12:58 ` Liam Girdwood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292936312.3296.8.camel@odin \
--to=lrg@slimlogic.co.uk \
--cc=axel.lin@gmail.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox