From: john stultz <johnstul@us.ibm.com>
To: "Kuwahara,T." <6vvetjsrt26xsrzlh1z0zn4d2grdah@gmail.com>
Cc: Richard Cochran <richardcochran@gmail.com>,
linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
netdev@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>,
Arnd Bergmann <arnd@arndb.de>, Christoph Lameter <cl@linux.com>,
David Miller <davem@davemloft.net>,
Krzysztof Halasa <khc@pm.waw.pl>,
Peter Zijlstra <peterz@infradead.org>,
Rodolfo Giometti <giometti@linux.it>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH V7 1/8] ntp: add ADJ_SETOFFSET mode bit
Date: Tue, 21 Dec 2010 14:25:55 -0800 [thread overview]
Message-ID: <1292970355.2618.76.camel@work-vm> (raw)
In-Reply-To: <AANLkTimJd5pScKTiDxuYd-h+NevYbCusyvUAqmUDXe8h@mail.gmail.com>
On Wed, 2010-12-22 at 05:57 +0900, Kuwahara,T. wrote:
> How about this?
>
> if (txc->modes & ADJ_OFFSET) {
> if (txc->constant == INT32_MIN) {
> /* step time */
> } else {
> /* slew time */
> }
> }
This looks like magic behavior. Sort of a "knock twice and then say the
password" interface. I don't see why that would be better then adding a
clear new mode flag?
> That said, I'm somehow against the idea of using the adjtimex syscall
> for that purpose.
Could you expand on why you don't like this?
thanks
-john
next prev parent reply other threads:[~2010-12-21 22:26 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-16 15:41 [PATCH V7 0/8] ptp: IEEE 1588 hardware clock support Richard Cochran
2010-12-16 15:41 ` [PATCH V7 1/8] ntp: add ADJ_SETOFFSET mode bit Richard Cochran
2010-12-16 17:48 ` Thomas Gleixner
2010-12-17 20:16 ` Kuwahara,T.
2010-12-21 7:56 ` Richard Cochran
2010-12-21 20:57 ` Kuwahara,T.
2010-12-21 22:25 ` john stultz [this message]
2010-12-22 7:13 ` Richard Cochran
2010-12-22 20:27 ` Kuwahara,T.
2010-12-23 0:00 ` john stultz
2010-12-23 6:13 ` Richard Cochran
2010-12-25 20:38 ` Kuwahara,T.
2010-12-26 14:14 ` Richard Cochran
2010-12-21 19:37 ` john stultz
2010-12-21 21:13 ` Kuwahara,T.
2010-12-21 21:59 ` john stultz
2010-12-22 7:11 ` Richard Cochran
2010-12-22 9:58 ` Alexander Gordeev
2010-12-16 15:42 ` [PATCH V7 2/8] posix clocks: introduce a syscall for clock tuning Richard Cochran
2010-12-16 15:51 ` Arnd Bergmann
2010-12-16 17:55 ` Thomas Gleixner
2010-12-16 15:43 ` [PATCH V7 3/8] posix clocks: introduce dynamic clocks Richard Cochran
2010-12-16 16:16 ` Arnd Bergmann
2010-12-16 20:56 ` Thomas Gleixner
2010-12-17 6:29 ` Richard Cochran
2010-12-16 15:43 ` [PATCH V7 4/8] posix clocks: hook dynamic clocks into system calls Richard Cochran
2010-12-16 23:20 ` Thomas Gleixner
2010-12-17 7:04 ` Richard Cochran
2010-12-17 10:03 ` Thomas Gleixner
2010-12-21 8:00 ` Richard Cochran
2010-12-22 8:21 ` Richard Cochran
2010-12-16 15:44 ` [PATCH V7 5/8] ptp: Added a brand new class driver for ptp clocks Richard Cochran
2010-12-16 15:57 ` Arnd Bergmann
2010-12-16 16:08 ` Rodolfo Giometti
2010-12-16 15:44 ` [PATCH V7 6/8] ptp: Added a clock that uses the eTSEC found on the MPC85xx Richard Cochran
2010-12-16 15:44 ` [PATCH V7 7/8] ptp: Added a clock driver for the IXP46x Richard Cochran
2011-01-02 8:45 ` Pavel Machek
2011-01-02 9:12 ` Richard Cochran
2011-01-02 9:20 ` Pavel Machek
2011-01-03 17:07 ` Richard Cochran
2011-01-06 20:04 ` Pavel Machek
2011-01-02 9:19 ` Richard Cochran
2010-12-16 15:45 ` [PATCH V7 8/8] ptp: Added a clock driver for the National Semiconductor PHYTER Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292970355.2618.76.camel@work-vm \
--to=johnstul@us.ibm.com \
--cc=6vvetjsrt26xsrzlh1z0zn4d2grdah@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arnd@arndb.de \
--cc=cl@linux.com \
--cc=davem@davemloft.net \
--cc=giometti@linux.it \
--cc=khc@pm.waw.pl \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=richardcochran@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox