Re: [RFC PATCH] perf: Add load latency monitoring on Intel Nehalem/Westmere

Peter Zijlstra
2010-12-22T09:04:21Z

On Wed, 2010-12-22 at 09:33 +0100, Peter Zijlstra wrote:
> On Wed, 2010-12-22 at 16:12 +0800, Lin Ming wrote:
> > It's applied on top of tip/master(3ea1f4f89) and Andi's offcore
> > patchsets are needed.
>
> I still haven't gotten a version of that I'm willing to apply.

That is, maybe you could pick up his patches and finish them, Andi
doesn't seem interested in getting them sorted.

I think the last posting lost the needs_percore logic, which would avoid
the percore allocations on platforms that don't need it (if we can
detect if HT is enabled that would be nice too).

I think he also lost the topology iteration (which can be used for both
the percore and the amd northbridge stuff), currently we iterate the
full machine looking for a matching nb/core_id, using a smaller topology
mask makes sense.

Also, after reading your patch, I think we want the MSR names in the
lists, not the numbers.