From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Amerigo Wang <amwang@redhat.com>
Cc: linux-kernel@vger.kernel.org, David Howells <dhowells@redhat.com>,
Koichi Yasutake <yasutake.koichi@jp.panasonic.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Yinghai Lu <yinghai@kernel.org>,
Tejun Heo <tj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Jens Axboe <jaxboe@fusionio.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Venkatesh Pallipadi <venki@google.com>,
linux-am33-list@redhat.com
Subject: Re: [PATCH] kernel: clean up USE_GENERIC_SMP_HELPERS
Date: Wed, 22 Dec 2010 14:08:53 +0100 [thread overview]
Message-ID: <1293023333.2170.120.camel@laptop> (raw)
In-Reply-To: <1291010778-5669-1-git-send-email-amwang@redhat.com>
On Mon, 2010-11-29 at 14:06 +0800, Amerigo Wang wrote:
> For arch which needs USE_GENERIC_SMP_HELPERS, it has to
> select USE_GENERIC_SMP_HELPERS, rather than leaving a choice
> to user, since they don't provide their own implementions.
>
> config MN10300_CURRENT_IN_E2
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index e330da2..736beea 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -65,6 +65,7 @@ config X86
> select HAVE_SPARSE_IRQ
> select GENERIC_IRQ_PROBE
> select GENERIC_PENDING_IRQ if SMP
> + select USE_GENERIC_SMP_HELPERS if SMP
>
> config INSTRUCTION_DECODER
> def_bool (KPROBES || PERF_EVENTS)
> @@ -203,10 +204,6 @@ config HAVE_INTEL_TXT
> def_bool y
> depends on EXPERIMENTAL && DMAR && ACPI
>
> -config USE_GENERIC_SMP_HELPERS
> - def_bool y
> - depends on SMP
> -
> config X86_32_SMP
> def_bool y
> depends on X86_32 && SMP
That changelog and the patch don't match, the patch is a total NOP,
users never see that config option.
next prev parent reply other threads:[~2010-12-22 13:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-29 6:06 [PATCH] kernel: clean up USE_GENERIC_SMP_HELPERS Amerigo Wang
2010-12-22 13:08 ` Peter Zijlstra [this message]
2010-12-23 10:02 ` Cong Wang
2010-12-23 10:21 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1293023333.2170.120.camel@laptop \
--to=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=amwang@redhat.com \
--cc=dhowells@redhat.com \
--cc=heiko.carstens@de.ibm.com \
--cc=hpa@zytor.com \
--cc=jaxboe@fusionio.com \
--cc=linux-am33-list@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=venki@google.com \
--cc=x86@kernel.org \
--cc=yasutake.koichi@jp.panasonic.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox