From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: linux-kernel@vger.kernel.org, mingo@redhat.com, hpa@zytor.com,
rostedt@goodmis.org, srostedt@redhat.com, tglx@linutronix.de
Cc: linux-tip-commits@vger.kernel.org
Subject: Re: [tip:perf/core] tracing: Only trace sched_wakeup if it actually work something up
Date: Wed, 22 Dec 2010 14:19:05 +0100 [thread overview]
Message-ID: <1293023945.2170.121.camel@laptop> (raw)
In-Reply-To: <tip-14bc7a06c6175cfa8070a5f5022210b648c3e0a7@git.kernel.org>
On Wed, 2010-12-22 at 13:16 +0000, tip-bot for Steven Rostedt wrote:
> Commit-ID: 14bc7a06c6175cfa8070a5f5022210b648c3e0a7
> Gitweb: http://git.kernel.org/tip/14bc7a06c6175cfa8070a5f5022210b648c3e0a7
> Author: Steven Rostedt <srostedt@redhat.com>
> AuthorDate: Thu, 2 Dec 2010 16:56:14 -0500
> Committer: Steven Rostedt <rostedt@goodmis.org>
> CommitDate: Fri, 3 Dec 2010 10:46:59 -0500
>
> tracing: Only trace sched_wakeup if it actually work something up
>
> Currently the tracepoint sched_wakeup traces the wakeup event even
> if the wakeup failed to wake anything up. This is quite stupid
> but it happens because we did not want to add a conditional
> to the core kernel code that would just slow down the wakeup events.
>
> This patch changes the wakeup tracepoints to use the
>
> DEFINE_EVENT_CONDITIONAL()
>
> to test the "success" parameter and will only trace the event if
> the wakeup was successfull.
>
> The success field in the tracepoint is removed since it is no
> longer needed.
I NAKed this, its stupid.
next parent reply other threads:[~2010-12-22 13:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tip-14bc7a06c6175cfa8070a5f5022210b648c3e0a7@git.kernel.org>
2010-12-22 13:19 ` Peter Zijlstra [this message]
2010-12-22 13:21 ` [tip:perf/core] tracing: Only trace sched_wakeup if it actually work something up Peter Zijlstra
2010-12-22 13:46 ` Steven Rostedt
2010-12-22 16:12 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1293023945.2170.121.camel@laptop \
--to=a.p.zijlstra@chello.nl \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=srostedt@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox