From: Huang Ying <ying.huang@intel.com>
To: "Valdis.Kletnieks@vt.edu" <Valdis.Kletnieks@vt.edu>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andi Kleen <andi@firstfloor.org>,
Peter Zijlstra <peterz@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [RFC -v9 0/4] Lock-less list
Date: Thu, 23 Dec 2010 16:31:19 +0800 [thread overview]
Message-ID: <1293093079.8743.179.camel@yhuang-dev> (raw)
In-Reply-To: <23265.1293084340@localhost>
Hi, Valdis,
Thanks for your comments.
On Thu, 2010-12-23 at 14:05 +0800, Valdis.Kletnieks@vt.edu wrote:
> On Thu, 23 Dec 2010 13:43:19 +0800, Huang Ying said:
> > Add a lock-less NULL-terminated linked list implementation. And use
> > that in irq_work and replace net/rds/xlist.h.
>
> A quick overview of the code looks mostly sane. What I don't see is
> an explanation of *why* this is being added. What benefits does it
> have over the current code? Is it faster? Smaller? Simply getting rid
> of near-duplicate versions in rds and irq_work? Something else?
The code is almost same. Just to avoid code duplicating, provide better
document, and make it easier for future users.
Best Regards,
Huang Ying
prev parent reply other threads:[~2010-12-23 8:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-23 5:43 [RFC -v9 0/4] Lock-less list Huang Ying
2010-12-23 5:43 ` [RFC -v9 1/4] Add Kconfig option ARCH_HAVE_NMI_SAFE_CMPXCHG Huang Ying
2010-12-23 17:35 ` David Miller
2010-12-24 0:56 ` Huang Ying
2010-12-23 5:43 ` [RFC -v9 2/4] lib, Add lock-less NULL terminated single list Huang Ying
2010-12-23 5:43 ` [RFC -v9 3/4] irq_work, Use llist in irq_work Huang Ying
2010-12-23 5:43 ` [RFC -v9 4/4] net, rds, Replace xlist in net/rds/xlist.h with llist Huang Ying
2010-12-23 7:05 ` Valdis.Kletnieks
2010-12-23 8:31 ` Huang Ying
2010-12-23 21:51 ` Chris Mason
2010-12-24 0:29 ` Huang Ying
2010-12-23 6:05 ` [RFC -v9 0/4] Lock-less list Valdis.Kletnieks
2010-12-23 8:31 ` Huang Ying [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1293093079.8743.179.camel@yhuang-dev \
--to=ying.huang@intel.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox