public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Huang Ying <ying.huang@intel.com>
To: David Miller <davem@davemloft.net>
Cc: "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"andi@firstfloor.org" <andi@firstfloor.org>,
	"peterz@infradead.org" <peterz@infradead.org>,
	"torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
	"mingo@elte.hu" <mingo@elte.hu>,
	"rth@twiddle.net" <rth@twiddle.net>,
	"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
	"starvik@axis.com" <starvik@axis.com>,
	"dhowells@redhat.com" <dhowells@redhat.com>,
	"ysato@users.sourceforge.jp" <ysato@users.sourceforge.jp>,
	"Luck, Tony" <tony.luck@intel.com>,
	"takata@linux-m32r.org" <takata@linux-m32r.org>,
	"geert@linux-m68k.org" <geert@linux-m68k.org>,
	"monstr@monstr.eu" <monstr@monstr.eu>,
	"ralf@linux-mips.org" <ralf@linux-mips.org>,
	"kyle@mcmartin.ca" <kyle@mcmartin.ca>,
	"schwidefsky@de.ibm.com" <schwidefsky@de.ibm.com>,
	"liqin.chen@sunplusct.com" <liqin.chen@sunplusct.com>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"chris@zankel.net" <chris@zankel.net>
Subject: Re: [RFC -v9 1/4] Add Kconfig option ARCH_HAVE_NMI_SAFE_CMPXCHG
Date: Fri, 24 Dec 2010 08:56:45 +0800	[thread overview]
Message-ID: <1293152205.22308.26.camel@yhuang-dev> (raw)
In-Reply-To: <20101223.093544.71126698.davem@davemloft.net>

Hi, David,

Thanks for review.

On Fri, 2010-12-24 at 01:35 +0800, David Miller wrote:
> From: Huang Ying <ying.huang@intel.com>
> Date: Thu, 23 Dec 2010 13:43:20 +0800
> 
> > --- a/arch/sparc/Kconfig
> > +++ b/arch/sparc/Kconfig
> > @@ -22,6 +22,7 @@ config SPARC
> >  	select RTC_CLASS
> >  	select RTC_DRV_M48T59
> >  	select HAVE_IRQ_WORK
> > +	select ARCH_HAVE_NMI_SAFE_CMPXCHG
> >  	select HAVE_DMA_ATTRS
> >  	select HAVE_DMA_API_DEBUG
> >  	select HAVE_ARCH_JUMP_LABEL
> 
> This should only be set for "SPARC64".  SPARC32's cmpxchg uses spinlocks and
> IRQ disabling, which is not NMI safe.

I will fix this.

Best Regards,
Huang Ying



  reply	other threads:[~2010-12-24  0:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-23  5:43 [RFC -v9 0/4] Lock-less list Huang Ying
2010-12-23  5:43 ` [RFC -v9 1/4] Add Kconfig option ARCH_HAVE_NMI_SAFE_CMPXCHG Huang Ying
2010-12-23 17:35   ` David Miller
2010-12-24  0:56     ` Huang Ying [this message]
2010-12-23  5:43 ` [RFC -v9 2/4] lib, Add lock-less NULL terminated single list Huang Ying
2010-12-23  5:43 ` [RFC -v9 3/4] irq_work, Use llist in irq_work Huang Ying
2010-12-23  5:43 ` [RFC -v9 4/4] net, rds, Replace xlist in net/rds/xlist.h with llist Huang Ying
2010-12-23  7:05   ` Valdis.Kletnieks
2010-12-23  8:31     ` Huang Ying
2010-12-23 21:51   ` Chris Mason
2010-12-24  0:29     ` Huang Ying
2010-12-23  6:05 ` [RFC -v9 0/4] Lock-less list Valdis.Kletnieks
2010-12-23  8:31   ` Huang Ying

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1293152205.22308.26.camel@yhuang-dev \
    --to=ying.huang@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=andi@firstfloor.org \
    --cc=chris@zankel.net \
    --cc=davem@davemloft.net \
    --cc=dhowells@redhat.com \
    --cc=geert@linux-m68k.org \
    --cc=kyle@mcmartin.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=liqin.chen@sunplusct.com \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=monstr@monstr.eu \
    --cc=peterz@infradead.org \
    --cc=ralf@linux-mips.org \
    --cc=rth@twiddle.net \
    --cc=schwidefsky@de.ibm.com \
    --cc=starvik@axis.com \
    --cc=takata@linux-m32r.org \
    --cc=tony.luck@intel.com \
    --cc=torvalds@linux-foundation.org \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox