Re: [PATCH v2 2/4] sh-pfc: Add emev2 pinmux support

Laurent Pinchart
2015-01-25T15:55:22Z

Hi Niklas,

On Sunday 25 January 2015 14:48:23 Niklas Söderlund wrote:
> Hi Laurent,
>
> Thanks for your comments.
>
> As note in your comments I have not grouped pins in groups where I have
> been uncertain if they can be used independently or not. I have read
> your input and made a v3 of the patch which address better grouping.
>
> I am a bit uncertain on how to best submit the updated patch. I will
> send just v3 of 2/4 to this thread. If you wish for me to send the
> complete series fresh let me.

I'll review 2/4 v3, but the usual practice is to resend the whole series,
especially when it's small.

> If I am to send the complete series once more do I add the 'Acked-by' to 1/4
> and 3/4 or not?

Yes, please collect the Acked-by lines in your tree and include them when you
resend patches or send a pull request.

--
Regards,

Laurent Pinchart