* Re: [PATCH v2 1/2] usb: ehci-s5p/ohci-exynos: Fix compatible strings for the device
@ 2013-01-25 2:04 Jingoo Han
0 siblings, 0 replies; 4+ messages in thread
From: Jingoo Han @ 2013-01-25 2:04 UTC (permalink / raw)
To: Vivek Gautam, linux-usb@vger.kernel.org
Cc: devicetree-discuss@lists.ozlabs.org, linux-kernel@vger.kernel.org,
linux-samsung-soc@vger.kernel.org, gregkh@linuxfoundation.org,
balbi@ti.com, stern@rowland.harvard.edu, Kukjin Kim,
thomas.abraham@linaro.org, rob.herring@calxeda.com,
grant.likely@secretlab.ca, sylvester.nawrocki@gmail.com,
dianders@chromium.org, Jingoo Han
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=euc-kr, Size: 728 bytes --]
On Thursday, January 24, 2013 10:45 PM, Vivek Gautam wrote
>
> Using specific chip in compatible strings. Newer SOCs can claim
> device by using older string in the compatible list.
>
> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
> Acked-by: Grant Likely <grant.likely@secretlab.ca>
> Reviewed-by: Doug Anderson <dianders@chromium.org>
Acked-by: Jingoo Han <jg1.han@samsung.com>
Best regards,
Jingoo Han
> ---
> drivers/usb/host/ehci-s5p.c | 2 +-
> drivers/usb/host/ohci-exynos.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
> ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v2 0/2] usb: exynos: Fix compatible strings used for device
@ 2013-01-24 13:45 Vivek Gautam
2013-01-24 13:45 ` [PATCH v2 1/2] usb: ehci-s5p/ohci-exynos: Fix compatible strings for the device Vivek Gautam
0 siblings, 1 reply; 4+ messages in thread
From: Vivek Gautam @ 2013-01-24 13:45 UTC (permalink / raw)
To: linux-usb
Cc: devicetree-discuss, linux-kernel, linux-samsung-soc, gregkh,
balbi, stern, kgene.kim, thomas.abraham, rob.herring,
grant.likely, sylvester.nawrocki, dianders, jg1.han, cpgs
Using chip specific compatible string as it should be.
So fixing this for ehci-s5p, ohci-exynos and dwc3-exynos
which till now used a generic 'exynos' in their compatible strings.
Changes from v1:
- Changing compatible string from "samsung,exynos5250-dwc3" to
"samsung,exynos5250-dwusb3" as per discussion happened in thread:
[PATCH 0/2] usb: exynos: Fix compatible strings used for device.
Vivek Gautam (2):
usb: ehci-s5p/ohci-exynos: Fix compatible strings for the device
usb: dwc3-exynos: Fix compatible strings for the device
drivers/usb/dwc3/dwc3-exynos.c | 2 +-
drivers/usb/host/ehci-s5p.c | 2 +-
drivers/usb/host/ohci-exynos.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
--
1.7.6.5
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2 1/2] usb: ehci-s5p/ohci-exynos: Fix compatible strings for the device
2013-01-24 13:45 [PATCH v2 0/2] usb: exynos: Fix compatible strings used for device Vivek Gautam
@ 2013-01-24 13:45 ` Vivek Gautam
2013-01-24 16:27 ` Alan Stern
2013-01-25 2:01 ` Jingoo Han
0 siblings, 2 replies; 4+ messages in thread
From: Vivek Gautam @ 2013-01-24 13:45 UTC (permalink / raw)
To: linux-usb
Cc: devicetree-discuss, linux-kernel, linux-samsung-soc, gregkh,
balbi, stern, kgene.kim, thomas.abraham, rob.herring,
grant.likely, sylvester.nawrocki, dianders, jg1.han, cpgs
Using specific chip in compatible strings. Newer SOCs can claim
device by using older string in the compatible list.
Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
Acked-by: Grant Likely <grant.likely@secretlab.ca>
Reviewed-by: Doug Anderson <dianders@chromium.org>
---
drivers/usb/host/ehci-s5p.c | 2 +-
drivers/usb/host/ohci-exynos.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/host/ehci-s5p.c b/drivers/usb/host/ehci-s5p.c
index 319dcfa..f18e6ac 100644
--- a/drivers/usb/host/ehci-s5p.c
+++ b/drivers/usb/host/ehci-s5p.c
@@ -266,7 +266,7 @@ static const struct dev_pm_ops s5p_ehci_pm_ops = {
#ifdef CONFIG_OF
static const struct of_device_id exynos_ehci_match[] = {
- { .compatible = "samsung,exynos-ehci" },
+ { .compatible = "samsung,exynos4210-ehci" },
{},
};
MODULE_DEVICE_TABLE(of, exynos_ehci_match);
diff --git a/drivers/usb/host/ohci-exynos.c b/drivers/usb/host/ohci-exynos.c
index aa3b884..77f2017 100644
--- a/drivers/usb/host/ohci-exynos.c
+++ b/drivers/usb/host/ohci-exynos.c
@@ -267,7 +267,7 @@ static const struct dev_pm_ops exynos_ohci_pm_ops = {
#ifdef CONFIG_OF
static const struct of_device_id exynos_ohci_match[] = {
- { .compatible = "samsung,exynos-ohci" },
+ { .compatible = "samsung,exynos4210-ohci" },
{},
};
MODULE_DEVICE_TABLE(of, exynos_ohci_match);
--
1.7.6.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2 1/2] usb: ehci-s5p/ohci-exynos: Fix compatible strings for the device
2013-01-24 13:45 ` [PATCH v2 1/2] usb: ehci-s5p/ohci-exynos: Fix compatible strings for the device Vivek Gautam
@ 2013-01-24 16:27 ` Alan Stern
2013-01-25 2:01 ` Jingoo Han
1 sibling, 0 replies; 4+ messages in thread
From: Alan Stern @ 2013-01-24 16:27 UTC (permalink / raw)
To: Vivek Gautam
Cc: linux-usb, devicetree-discuss, linux-kernel, linux-samsung-soc,
gregkh, balbi, kgene.kim, thomas.abraham, rob.herring,
grant.likely, sylvester.nawrocki, dianders, jg1.han, cpgs
On Thu, 24 Jan 2013, Vivek Gautam wrote:
> Using specific chip in compatible strings. Newer SOCs can claim
> device by using older string in the compatible list.
>
> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
> Acked-by: Grant Likely <grant.likely@secretlab.ca>
> Reviewed-by: Doug Anderson <dianders@chromium.org>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 1/2] usb: ehci-s5p/ohci-exynos: Fix compatible strings for the device
2013-01-24 13:45 ` [PATCH v2 1/2] usb: ehci-s5p/ohci-exynos: Fix compatible strings for the device Vivek Gautam
2013-01-24 16:27 ` Alan Stern
@ 2013-01-25 2:01 ` Jingoo Han
1 sibling, 0 replies; 4+ messages in thread
From: Jingoo Han @ 2013-01-25 2:01 UTC (permalink / raw)
To: 'Vivek Gautam', linux-usb
Cc: devicetree-discuss, linux-kernel, linux-samsung-soc, gregkh,
balbi, stern, kgene.kim, thomas.abraham, rob.herring,
grant.likely, sylvester.nawrocki, dianders, cpgs,
'Jingoo Han'
On Thursday, January 24, 2013 10:45 PM, Vivek Gautam wrote
>
> Using specific chip in compatible strings. Newer SOCs can claim
> device by using older string in the compatible list.
>
> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
> Acked-by: Grant Likely <grant.likely@secretlab.ca>
> Reviewed-by: Doug Anderson <dianders@chromium.org>
Acked-by: Jingoo Han <jg1.han@samsung.com>
Best regards,
Jingoo Han
> ---
> drivers/usb/host/ehci-s5p.c | 2 +-
> drivers/usb/host/ohci-exynos.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-01-25 2:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-25 2:04 [PATCH v2 1/2] usb: ehci-s5p/ohci-exynos: Fix compatible strings for the device Jingoo Han
-- strict thread matches above, loose matches on Subject: below --
2013-01-24 13:45 [PATCH v2 0/2] usb: exynos: Fix compatible strings used for device Vivek Gautam
2013-01-24 13:45 ` [PATCH v2 1/2] usb: ehci-s5p/ohci-exynos: Fix compatible strings for the device Vivek Gautam
2013-01-24 16:27 ` Alan Stern
2013-01-25 2:01 ` Jingoo Han
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox