From: Peter Zijlstra <peterz@infradead.org>
To: Tejun Heo <tj@kernel.org>
Cc: Ingo Molnar <mingo@redhat.com>, "Rafael J. Wysocki" <rjw@sisk.pl>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH UPDATED] workqueue: relax lockdep annotation on flush_work()
Date: Mon, 03 Jan 2011 16:29:05 +0100 [thread overview]
Message-ID: <1294068545.2016.85.camel@laptop> (raw)
In-Reply-To: <20110103152017.GV18831@htj.dyndns.org>
On Mon, 2011-01-03 at 16:20 +0100, Tejun Heo wrote:
> On Mon, Jan 03, 2011 at 04:14:45PM +0100, Peter Zijlstra wrote:
> > > Hmmm? The code applies the most strict contraints. If the workqueue
> > > has a rescuer, flushing another work from the workqueue will always
> > > trigger lockdep warning. The rule is relaxed only for workqueues
> > > which aren't used for memory reclaiming && support parallel execution.
> >
> > Ah, ok. I read it like: if the current thread is a rescue thread.
>
> Ah, I see. Rafael, can you please verify the updated version is okay
> too (it should be but just in case)? Peter, shall I route this
> through workqueue tree with your ack?
That's fine with me, thanks!
next prev parent reply other threads:[~2011-01-03 15:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-29 12:57 [PATCH] workqueue: relax lockdep annotation on flush_work() Tejun Heo
2010-12-29 14:20 ` Rafael J. Wysocki
2011-01-03 9:31 ` Peter Zijlstra
2011-01-03 14:17 ` [PATCH UPDATED] " Tejun Heo
2011-01-03 14:54 ` Peter Zijlstra
2011-01-03 15:00 ` Tejun Heo
2011-01-03 15:14 ` Peter Zijlstra
2011-01-03 15:20 ` Tejun Heo
2011-01-03 15:29 ` Peter Zijlstra [this message]
2011-01-03 21:25 ` Rafael J. Wysocki
2011-01-09 22:34 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294068545.2016.85.camel@laptop \
--to=peterz@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rjw@sisk.pl \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox