public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: Ingo Molnar <mingo@elte.hu>,
	"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
	Arnd Bergmann <arnd@arndb.de>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] sched: add __rcu annotation
Date: Tue, 04 Jan 2011 11:17:47 +0100	[thread overview]
Message-ID: <1294136267.2016.105.camel@laptop> (raw)
In-Reply-To: <4D22D4EE.3020604@cn.fujitsu.com>

On Tue, 2011-01-04 at 16:06 +0800, Lai Jiangshan wrote:
> Add __rcu annotation to :
> 	(struct rq)->sd

That's a broken changelog, it's about as good as:

 i++; /* increment i */

I'm really starting to detest sparse (lock annotations), it keeps adding
these annotations, but does it ever catch an actual bug?

  reply	other threads:[~2011-01-04 10:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-04  8:06 [PATCH 1/3] sched: add __rcu annotation Lai Jiangshan
2011-01-04 10:17 ` Peter Zijlstra [this message]
2011-01-04 10:55   ` Eric Dumazet
2011-01-04 11:01     ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1294136267.2016.105.camel@laptop \
    --to=a.p.zijlstra@chello.nl \
    --cc=arnd@arndb.de \
    --cc=laijs@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulmck@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox