From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Lin Ming <ming.m.lin@intel.com>
Cc: Ingo Molnar <mingo@elte.hu>, Andi Kleen <andi@firstfloor.org>,
Stephane Eranian <eranian@google.com>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 6/7] perf: Use MSR names in the extra reg lists
Date: Tue, 04 Jan 2011 13:07:05 +0100 [thread overview]
Message-ID: <1294142825.2016.134.camel@laptop> (raw)
In-Reply-To: <1293464296.2695.107.camel@localhost>
On Mon, 2010-12-27 at 23:38 +0800, Lin Ming wrote:
> @@ -88,7 +88,8 @@ static struct event_constraint intel_nehalem_event_constraints[] =
>
> static struct extra_reg intel_nehalem_extra_regs[] =
> {
> - INTEL_EVENT_EXTRA_REG(0xb7, 0x1a6, 0xffff, 32), /* OFFCORE_RESPONSE */
> + /* OFFCORE_RESPONSE */
> + INTEL_EVENT_EXTRA_REG(0xb7, MSR_OFFCORE_RSP_0, 0xffff, 32),
> EVENT_EXTRA_END
> };
Since we're going for another posting anyway, I think you can drop that
comment here, it should be evident from the MSR name included in the
constraint.
prev parent reply other threads:[~2011-01-04 12:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-27 15:38 [PATCH 6/7] perf: Use MSR names in the extra reg lists Lin Ming
2011-01-04 12:07 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294142825.2016.134.camel@laptop \
--to=a.p.zijlstra@chello.nl \
--cc=andi@firstfloor.org \
--cc=eranian@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox