From: John Stultz <john.stultz@linaro.org>
To: Richard Cochran <richardcochran@gmail.com>
Cc: "Kuwahara,T." <6vvetjsrt26xsrzlh1z0zn4d2grdah@gmail.com>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Richard Cochran <richard.cochran@omicron.at>
Subject: Re: [PATCH 2/3] ntp: add ADJ_SETOFFSET mode bit
Date: Tue, 04 Jan 2011 11:14:14 -0800 [thread overview]
Message-ID: <1294168454.2694.9.camel@work-vm> (raw)
In-Reply-To: <20110104084023.GB4563@riccoc20.at.omicron.at>
On Tue, 2011-01-04 at 09:40 +0100, Richard Cochran wrote:
> On Mon, Jan 03, 2011 at 12:44:26PM -0800, John Stultz wrote:
> > Richard: Maybe this is a good thing to think about for clock_adjtime? If
> > we are adding a new syscall, maybe we should make sure we clean up some
> > of the old syscalls issues? It does add a good bit of complexity, as the
> > idea of clock_adjtime being a multiplexing adjtimex was nice and simple.
> > We'd also have to review the mode usage to see if multi-mode adjustments
> > in a single call are all that common or not.
>
> So, is the NTP source code the documentation of the kernel interface?
Yea. adjtimex is a combination of ntp_adjtime and the older adjtime
interfaces. So its not identical to David Mill's design, but it is
compatible. In fact, it wasn't until somewhat recently that it picked
up the ntpv4 changes and MOD/ADJ_NANO.
By the way, I'm not saying we should switch from using mode flags to
mode numbers for the new interface as I'm not sure if it would confuse
users moving to it (being very similar, but slightly different can be
worse then being totally different). But I figure it warrants some
consideration. We do still have 4 unused bits in the modes flags after
your patch, so this may be a premature worry.
thanks
-john
next prev parent reply other threads:[~2011-01-04 19:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-27 23:40 [PATCH 0/3] Cleanup ADJ_SETOFFSET patch John Stultz
2010-12-27 23:40 ` [PATCH 1/3] time: Introduce timekeeping_inject_offset John Stultz
2010-12-27 23:40 ` [PATCH 2/3] ntp: add ADJ_SETOFFSET mode bit John Stultz
2010-12-28 20:47 ` Kuwahara,T.
2011-01-03 20:44 ` John Stultz
2011-01-04 8:37 ` Richard Cochran
2011-01-04 19:08 ` John Stultz
[not found] ` <12d52d09b05.7801197194177918524.-8125715123212004756@gmail.com>
2011-01-05 7:00 ` Richard Cochran
2011-01-04 8:40 ` Richard Cochran
2011-01-04 19:14 ` John Stultz [this message]
2010-12-27 23:40 ` [PATCH 3/3] ntp: Change ADJ_SETOFFSET implementation to use timekeeping_inject_offset John Stultz
2010-12-28 11:20 ` [PATCH 0/3] Cleanup ADJ_SETOFFSET patch Richard Cochran
2010-12-28 12:53 ` Richard Cochran
2010-12-28 13:36 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294168454.2694.9.camel@work-vm \
--to=john.stultz@linaro.org \
--cc=6vvetjsrt26xsrzlh1z0zn4d2grdah@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=richard.cochran@omicron.at \
--cc=richardcochran@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox