From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751309Ab1ADXqk (ORCPT ); Tue, 4 Jan 2011 18:46:40 -0500 Received: from mail.linux-iscsi.org ([67.23.28.174]:36776 "EHLO linux-iscsi.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750892Ab1ADXqj (ORCPT ); Tue, 4 Jan 2011 18:46:39 -0500 Subject: Re: [patch 2/2] [SCSI] target: unlock on error path in configfs From: "Nicholas A. Bellinger" To: Dan Carpenter Cc: James Bottomley , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-scsi@vger.kernel.org In-Reply-To: <20110103055920.GV1886@bicker> References: <20110103055920.GV1886@bicker> Content-Type: text/plain Date: Tue, 04 Jan 2011 15:40:37 -0800 Message-Id: <1294184437.29002.24.camel@haakon2.linux-iscsi.org> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2011-01-03 at 08:59 +0300, Dan Carpenter wrote: > If the user wrote a wrong value to the file the it would lead to a dead > lock eventually. > Good catch on this one. Commited as 827447968 and pushed into lio-core-2.6.git. Thanks! --nab > Signed-off-by: Dan Carpenter > > diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c > index d7b977d..2764510 100644 > --- a/drivers/target/target_core_configfs.c > +++ b/drivers/target/target_core_configfs.c > @@ -660,6 +660,7 @@ static ssize_t target_core_dev_store_attr_##_name( \ > } \ > ret = strict_strtoul(page, 0, &val); \ > if (ret < 0) { \ > + spin_unlock(&se_dev->se_dev_lock); \ > printk(KERN_ERR "strict_strtoul() failed with" \ > " ret: %d\n", ret); \ > return -EINVAL; \