public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@suse.de>
To: DuanZhenzhong <zhenzhong.duan@oracle.com>
Cc: Jeff Garzik <jeff@garzik.org>,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: declare MODULE_FIRMWARE in libsas
Date: Tue, 04 Jan 2011 22:36:32 -0600	[thread overview]
Message-ID: <1294202192.7879.30.camel@mulgrave.site> (raw)
In-Reply-To: <4D23E315.9060900@oracle.com>

On Wed, 2011-01-05 at 11:18 +0800, DuanZhenzhong wrote:
> Jeff Garzik 写道:
> > On 01/04/2011 09:08 AM, James Bottomley wrote:
> >> On Tue, 2011-01-04 at 15:43 +0800, DuanZhenzhong wrote:
> >>> Signed-off-by: Zhenzhong Duan<zhenzhong.duan@oracle.com>
> >>>
> >>> ---
> >>
> >> Description?  Since libsas has no firmware, surely some explanation is
> >> required.
> >
> > Indeed.  Looks bogus at first glance?
> >
> >
> I was finding all requested but not exported firmware in scsi driver for 
> generating dump initrd use.
> In sas_scsi_host.c, request_firmware is called with "sas_addr", sas_addr 
> neither builtin nor exported. Don't sas_addr a firmware? Please correct 
> me. thanks

No, it's not requesting any firmware ... it's a slight misuse of the
firmware mechanism that allows a libsas based driver to be given a SAS
address if it doesn't have an internal nsvram to store one.

James



  reply	other threads:[~2011-01-05  4:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-04  7:43 declare MODULE_FIRMWARE in libsas DuanZhenzhong
2011-01-04 14:08 ` James Bottomley
2011-01-04 17:45   ` Jeff Garzik
2011-01-05  3:18     ` DuanZhenzhong
2011-01-05  4:36       ` James Bottomley [this message]
2011-01-05  5:27         ` DuanZhenzhong
2011-01-05  4:47       ` Américo Wang
2011-01-05  5:28         ` DuanZhenzhong
2011-01-05  5:42           ` Américo Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1294202192.7879.30.camel@mulgrave.site \
    --to=james.bottomley@suse.de \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=zhenzhong.duan@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox