From: Russ Gorby <russ.gorby@intel.com>
To: Greg@vger.kernel.org, Kroah-Hartman@vger.kernel.org,
<gregkh@suse.de>,
Vasiliy@vger.kernel.org, Kulikov@vger.kernel.org,
<segoon@openwall.com>,
Alan@vger.kernel.org, Cox@vger.kernel.org, <alan@linux.intel.com>,
Russ@vger.kernel.org, Gorby@vger.kernel.org,
<richardx.r.gorby@intel.com>,
linux-kernel@vger.kernel.org
Cc: suhail.ahmed@intel.com
Subject: [PATCH 1/7] serial: ifx6x60: fixed call to tty_port_init
Date: Wed, 5 Jan 2011 16:05:07 -0800 [thread overview]
Message-ID: <1294272313-15899-2-git-send-email-russ.gorby@intel.com> (raw)
In-Reply-To: <[PATCH 0/7] IFX6X60 patchset: 01/05/2011>
The port ops must be set AFTER calling port init as that function
zeroes the structure
Signed-off-by: Russ Gorby <russ.gorby@intel.com>
---
drivers/serial/ifx6x60.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/serial/ifx6x60.c b/drivers/serial/ifx6x60.c
index ab93763..1eb44f9 100644
--- a/drivers/serial/ifx6x60.c
+++ b/drivers/serial/ifx6x60.c
@@ -798,8 +798,8 @@ static int ifx_spi_create_port(struct ifx_spi_device *ifx_dev)
goto error_ret;
}
- pport->ops = &ifx_tty_port_ops;
tty_port_init(pport);
+ pport->ops = &ifx_tty_port_ops;
ifx_dev->minor = IFX_SPI_TTY_ID;
ifx_dev->tty_dev = tty_register_device(tty_drv, ifx_dev->minor,
&ifx_dev->spi_dev->dev);
--
1.7.2.3
next prev parent reply other threads:[~2011-01-06 0:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <[PATCH 0/7] IFX6X60 patchset: 01/05/2011>
2011-01-06 0:05 ` [PATCH 0/7] IFX6X60 patchset: 01/05/2011 Russ Gorby
2011-01-06 0:14 ` Greg KH
2011-01-06 0:33 ` Gorby, Russ
2011-01-06 3:19 ` Greg KH
2011-01-06 0:05 ` Russ Gorby [this message]
2011-01-06 0:24 ` [PATCH 1/7] serial: ifx6x60: fixed call to tty_port_init Alan Cox
2011-01-06 0:05 ` [PATCH 2/7] serial: ifx6x60: dma_alloc_coherent must use parent dev Russ Gorby
2011-01-06 0:05 ` [PATCH 3/7] serial: ifx6x60: changed internal bpw from boolean to int Russ Gorby
2011-01-06 0:25 ` Alan Cox
2011-01-06 0:05 ` [PATCH 4/7] serial: ifx6x60: set SPI max_speed_hz based on platform type Russ Gorby
2011-01-06 0:27 ` Alan Cox
2011-01-06 21:30 ` Gorby, Russ
2011-01-10 14:05 ` Alan Cox
2011-01-06 0:05 ` [PATCH 5/7] serial: ifx6x60: probe routine needs to call spi_setup Russ Gorby
2011-01-06 0:05 ` [PATCH 6/7] serial: ifx6x60: fix modem names to ones recognized by firmware Russ Gorby
2011-01-06 0:29 ` Alan Cox
2011-01-06 0:05 ` [PATCH 7/7] serial: ifx6x60: minor cleanup Russ Gorby
2011-01-06 0:29 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294272313-15899-2-git-send-email-russ.gorby@intel.com \
--to=russ.gorby@intel.com \
--cc=Alan@vger.kernel.org \
--cc=Cox@vger.kernel.org \
--cc=Gorby@vger.kernel.org \
--cc=Greg@vger.kernel.org \
--cc=Kroah-Hartman@vger.kernel.org \
--cc=Kulikov@vger.kernel.org \
--cc=Russ@vger.kernel.org \
--cc=Vasiliy@vger.kernel.org \
--cc=alan@linux.intel.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=richardx.r.gorby@intel.com \
--cc=segoon@openwall.com \
--cc=suhail.ahmed@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox