From: Mailing Lists <listsm@yahoo.ca>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch] vga_switcheroo: comparing too few characters in strncmp()
Date: Thu, 06 Jan 2011 23:07:22 -0700 [thread overview]
Message-ID: <1294380442.10605.25.camel@Tachyon> (raw)
In-Reply-To: <20110107053054.GA9057@p183.telecom.by>
On Fri, 2011-01-07 at 07:30 +0200, Alexey Dobriyan wrote:
> On Fri, Jan 07, 2011 at 08:12:27AM +0300, Dan Carpenter wrote:
> > This is a copy-and-paste bug. We should be comparing 4 characters here
> > instead of 3.
>
> > --- a/drivers/gpu/vga/vga_switcheroo.c
> > +++ b/drivers/gpu/vga/vga_switcheroo.c
> > @@ -346,11 +346,11 @@ vga_switcheroo_debugfs_write(struct file *filp, const char __user *ubuf,
> > if (strncmp(usercmd, "DIS", 3) == 0)
> > client_id = VGA_SWITCHEROO_DIS;
> >
> > - if (strncmp(usercmd, "MIGD", 3) == 0) {
> > + if (strncmp(usercmd, "MIGD", 4) == 0) {
> > just_mux = true;
> > client_id = VGA_SWITCHEROO_IGD;
> > }
> > - if (strncmp(usercmd, "MDIS", 3) == 0) {
> > + if (strncmp(usercmd, "MDIS", 4) == 0) {
>
> How about you NUL-terminate, and use strcmp().
Userspace data? How to guarantee NULL terminated string at runtime?
Still, the string constants being compared against are already NULL
terminated, so he could use strcmp as is.
Also, strcmp() would discard user strings that start with a matching
substring ("DIS", "DISK", "DISH", "DISINTERESTED" would all set
client_id to VGA_SWITCHEROO_DIS, using strncmp(), but strcmp() would
only match "DIS").
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
prev parent reply other threads:[~2011-01-07 6:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-07 5:12 [patch] vga_switcheroo: comparing too few characters in strncmp() Dan Carpenter
2011-01-07 5:30 ` Alexey Dobriyan
2011-01-07 6:05 ` Dan Carpenter
2011-01-07 6:07 ` Mailing Lists [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294380442.10605.25.camel@Tachyon \
--to=listsm@yahoo.ca \
--cc=adobriyan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox