From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>, Greg KH <greg@kroah.com>,
Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
"H. Peter Anvin" <hpa@zytor.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
linux-usb@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sarah Sharp <sarah.a.sharp@linux.intel.com>
Subject: Re: [PATCH 1/3] pci, usb: Seperate usb handoff func to another file
Date: Mon, 10 Jan 2011 20:38:16 +1100 [thread overview]
Message-ID: <1294652296.17779.299.camel@pasglop> (raw)
In-Reply-To: <4D2AAEDD.5060604@kernel.org>
On Sun, 2011-01-09 at 23:01 -0800, Yinghai Lu wrote:
> On 01/09/2011 01:09 PM, Benjamin Herrenschmidt wrote:
> > acceptable ?
> >
> > I think if you want to make the handoff happen -that- early, you have
> > basically two options. One is to move it all to arch code, and the other
> > one is to create early-boot "fake" struct pci_dev & bus that have the
> > config callbacks implemented pointing to the early stuff. You can do
> > that entirely within your arch code, and avoids most of the grossness
> > above in the generic places.
>
> good idea, will make one get_early_pci_dev() for x86 as dummy device.
>
> >
> > It would avoid that turd too:
> >
> >> +#include "usb_handoff.c"
>
> may still need that to avoid some MMIO bar finding and remapping etc.
Might be better to test for system state... a bit ugly too but less than
#include'ing the C file.
Cheers,
Ben.
next prev parent reply other threads:[~2011-01-10 9:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4D2A1152.1040903@kernel.org>
2011-01-09 19:59 ` [PATCH 1/3] pci, usb: Seperate usb handoff func to another file Yinghai Lu
2011-01-09 21:09 ` Benjamin Herrenschmidt
2011-01-10 7:01 ` Yinghai Lu
2011-01-10 9:38 ` Benjamin Herrenschmidt [this message]
2011-01-10 15:57 ` Greg KH
2011-01-09 19:59 ` [PATCH 2/3] x86: early_quirk check all dev/func in domain 0 Yinghai Lu
2011-01-10 16:01 ` Greg KH
2011-01-10 19:53 ` Yinghai Lu
2011-01-09 19:59 ` [PATCH 3/3] x86: usb handoff in early_quirk Yinghai Lu
2011-01-10 16:00 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294652296.17779.299.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=greg@kroah.com \
--cc=hpa@zytor.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sarah.a.sharp@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox