From: john stultz <johnstul@us.ibm.com>
To: "Kuwahara,T." <6vvetjsrt26xsrzlh1z0zn4d2grdah@gmail.com>
Cc: Richard Cochran <richardcochran@gmail.com>,
linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
netdev@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>,
Arnd Bergmann <arnd@arndb.de>, Christoph Lameter <cl@linux.com>,
David Miller <davem@davemloft.net>,
Krzysztof Halasa <khc@pm.waw.pl>,
Peter Zijlstra <peterz@infradead.org>,
Rodolfo Giometti <giometti@linux.it>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH V8 02/13] ntp: add ADJ_SETOFFSET mode bit
Date: Mon, 10 Jan 2011 13:11:32 -0800 [thread overview]
Message-ID: <1294693892.3068.17.camel@work-vm> (raw)
In-Reply-To: <AANLkTimS0-ih=WZ_GvPi9NFjbYMT4OctWV943ri4GuTD@mail.gmail.com>
On Tue, 2011-01-11 at 05:47 +0900, Kuwahara,T. wrote:
> On Mon, Jan 10, 2011 at 4:17 PM, Richard Cochran
> <richardcochran@gmail.com> wrote:
> > the PTP Hardware Clocks for which this whole patch
> > set was created in the first place will keep their time as TAI.
>
> Are you sure of that? I don't have the standard handy (it's non-free,
> right?) but it seems that the Annex B states differently. But that's
> not the point anyway. My concern is that your patch not only adds the
> useless (and broken) feature to the existing syscall but also makes a
> permanent change to the public interface for your own use. That's
> what I'm against. So if you stop touching the struct timex, I won't
> complain anymore.
You still haven't explained *why* you're so protective of the timex and
adjtimex interfaces. While I do want to keep compatible the
functionality where possible, I don't see why Linux should be limited by
what other OSes do.
Injecting an offset to the system time seems like a reasonable thing for
adjtimex to do (rather then adding a new syscall). Further utilizing a
new mode bit for this functionality seems reasonable and cleaner then
your suggestions for utilizing existing mode bits in combined with other
magic bits. If there is a compelling reason why not to do this, do
please let us know! We might just agree with you after hearing it. :)
thanks
-john
next prev parent reply other threads:[~2011-01-10 21:11 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-31 19:11 [PATCH V8 00/13] ptp: IEEE 1588 hardware clock support Richard Cochran
2010-12-31 19:12 ` [PATCH V8 01/13] time: Introduce timekeeping_inject_offset John Stultz
2011-01-06 22:00 ` Arnd Bergmann
2010-12-31 19:12 ` [PATCH V8 02/13] ntp: add ADJ_SETOFFSET mode bit Richard Cochran
2011-01-01 20:38 ` Kuwahara,T.
2011-01-08 17:50 ` Richard Cochran
2011-01-09 21:07 ` Kuwahara,T.
2011-01-10 7:17 ` Richard Cochran
2011-01-10 20:47 ` Kuwahara,T.
2011-01-10 21:11 ` john stultz [this message]
2011-01-11 11:09 ` Richard Cochran
2011-01-10 7:22 ` Richard Cochran
2011-01-10 16:49 ` john stultz
2011-01-10 20:45 ` Kuwahara,T.
2011-01-10 21:06 ` john stultz
2011-01-11 20:32 ` Kuwahara,T.
2011-01-11 20:55 ` john stultz
2011-01-12 20:39 ` Kuwahara,T.
2011-01-12 20:55 ` john stultz
2010-12-31 19:13 ` [PATCH V8 03/13] posix clocks: introduce a syscall for clock tuning Richard Cochran
2010-12-31 19:13 ` [PATCH V8 04/13] posix_clocks: add clock_adjtime for arm Richard Cochran
2010-12-31 19:14 ` [PATCH V8 05/13] posix_clocks: add clock_adjtime for blackfin Richard Cochran
2010-12-31 19:14 ` [PATCH V8 06/13] posix_clocks: add clock_adjtime for powerpc Richard Cochran
2010-12-31 19:14 ` [PATCH V8 07/13] posix_clocks: add clock_adjtime for x86 Richard Cochran
2010-12-31 19:15 ` [PATCH V8 08/13] posix clocks: cleanup the CLOCK_DISPTACH macro Richard Cochran
2011-01-03 9:29 ` Peter Zijlstra
2011-01-03 11:51 ` Richard Cochran
2011-01-11 12:57 ` Thomas Gleixner
2011-01-12 7:37 ` Richard Cochran
2011-01-12 11:16 ` Thomas Gleixner
2011-01-12 12:17 ` Richard Cochran
2011-01-13 4:30 ` Richard Cochran
2011-01-13 11:25 ` Thomas Gleixner
2010-12-31 19:15 ` [PATCH V8 09/13] posix clocks: introduce dynamic clocks Richard Cochran
2011-01-06 19:56 ` Arnd Bergmann
2011-01-07 16:41 ` Richard Cochran
2010-12-31 19:16 ` [PATCH V8 10/13] ptp: Added a brand new class driver for ptp clocks Richard Cochran
2010-12-31 19:16 ` [PATCH V8 11/13] ptp: Added a clock that uses the eTSEC found on the MPC85xx Richard Cochran
2010-12-31 19:17 ` [PATCH V8 12/13] ptp: Added a clock driver for the IXP46x Richard Cochran
2011-01-06 21:01 ` Krzysztof Halasa
2011-01-07 17:07 ` Richard Cochran
2011-01-08 16:25 ` Krzysztof Halasa
2011-01-10 20:24 ` Krzysztof Halasa
2010-12-31 19:17 ` [PATCH V8 13/13] ptp: Added a clock driver for the National Semiconductor PHYTER Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294693892.3068.17.camel@work-vm \
--to=johnstul@us.ibm.com \
--cc=6vvetjsrt26xsrzlh1z0zn4d2grdah@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arnd@arndb.de \
--cc=cl@linux.com \
--cc=davem@davemloft.net \
--cc=giometti@linux.it \
--cc=khc@pm.waw.pl \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=richardcochran@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox