From: Peter Zijlstra <peterz@infradead.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: David Miller <davem@davemloft.net>,
linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org
Subject: Re: sparc boot failure due to perf init
Date: Thu, 13 Jan 2011 13:33:26 +0100 [thread overview]
Message-ID: <1294922006.19601.106.camel@laptop> (raw)
In-Reply-To: <20110113122505.GA27522@merkur.ravnborg.org>
On Thu, 2011-01-13 at 13:25 +0100, Sam Ravnborg wrote:
> > > }
> > >
> > > -arch_initcall(pcr_arch_init);
> > > +early_initcall(pcr_arch_init);
> >
> >
> > I just realized, doesn't this make bootability depend on link order?
> Yes.
>
> > Since both the pmu init and its dependencies are now early_initcall()
> > how do we guarantee pcr_arch_init() and cpu_type_probe() are in fact
> > called _before_ init_hw_perf_events()?
>
> Today this is achieved by perf_event.o being located last
> in the Makefile in arch/sparc/kernel/
>
> It deserves a comment..
Ah, right! and while make -j will compile concurrently, link order is
still maintained, and I guess until the linker decides to process its
input files in random order (or reverse order, or whatever) we're good.
Does something like GOLD which was supposed to be threaded or somesuch
still work as expected here?
next prev parent reply other threads:[~2011-01-13 12:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-07 20:18 sparc boot failure due to perf init Sam Ravnborg
2011-01-07 20:22 ` Sam Ravnborg
2011-01-07 20:23 ` Peter Zijlstra
2011-01-07 20:27 ` Peter Zijlstra
2011-01-07 20:31 ` Sam Ravnborg
2011-01-09 23:37 ` David Miller
2011-01-10 15:21 ` Peter Zijlstra
2011-01-13 10:55 ` Peter Zijlstra
2011-01-13 12:25 ` Sam Ravnborg
2011-01-13 12:33 ` Peter Zijlstra [this message]
2011-01-13 20:25 ` David Miller
2011-01-08 2:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294922006.19601.106.camel@laptop \
--to=peterz@infradead.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox