public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Bojan Smojver <bojan@rexursive.com>
To: "Ted Ts'o" <tytso@mit.edu>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>,
	pm list <linux-pm@lists.linux-foundation.org>,
	"linux-ext4@vger.kernel.org development"
	<linux-ext4@vger.kernel.org>,
	LKML Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [linux-pm] Oops while going into hibernate
Date: Fri, 14 Jan 2011 08:30:12 +1100	[thread overview]
Message-ID: <1294954212.2781.8.camel@shrek.rexursive.com> (raw)
In-Reply-To: <20110113184626.GA31800@thunk.org>

On Thu, 2011-01-13 at 13:46 -0500, Ted Ts'o wrote:
> I'm still a bit concerned with the call to set the pages' PTE to be
> dirty that I found in the hibernate code, but I accept the fact that
> removing it doesn't solve the s390 crash.  It still seems wrong to me,
> and hopefully someone from linux-pm can look at that more closely. 

If I'm understanding things correctly, this should affect only the
situation when compression is not used. Otherwise, pages that are read
into by block I/O are decompressed first and copied into different
pages. No?

-- 
Bojan


  reply	other threads:[~2011-01-13 21:30 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-12 13:48 Oops while going into hibernate Sebastian Ott
2011-01-12 16:26 ` Ted Ts'o
2011-01-12 16:56   ` Sebastian Ott
2011-01-12 17:26     ` Ted Ts'o
2011-01-12 17:37       ` Sebastian Ott
2011-01-12 18:49       ` Sebastian Ott
2011-01-13  0:44         ` Theodore Tso
2011-01-13  5:56           ` Ted Ts'o
2011-01-13  5:59             ` [PATCH] PM / Hibernate: Don't mark pages dirty when reading pages while thawing Theodore Ts'o
2011-01-13 12:36               ` Sebastian Ott
2011-01-13 11:12           ` [linux-pm] Oops while going into hibernate Bojan Smojver
2011-01-13 11:49             ` Sebastian Ott
2011-01-13 11:48           ` Sebastian Ott
2011-01-13 12:11             ` [linux-pm] " Bojan Smojver
2011-01-13 12:31               ` Sebastian Ott
2011-01-13 13:36             ` Heiko Carstens
2011-01-13 18:46               ` Ted Ts'o
2011-01-13 21:30                 ` Bojan Smojver [this message]
2011-01-14  9:53                   ` [linux-pm] " Heiko Carstens
2011-01-14 13:14                     ` Bojan Smojver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1294954212.2781.8.camel@shrek.rexursive.com \
    --to=bojan@rexursive.com \
    --cc=heiko.carstens@de.ibm.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox