From: Frederic Weisbecker <fweisbec@gmail.com>
To: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Paul Mackerras <paulus@samba.org>
Subject: [PATCH 4/4] perf: Don't give arbitrary gender to callchain tree nodes
Date: Fri, 14 Jan 2011 04:52:01 +0100 [thread overview]
Message-ID: <1294977121-5700-5-git-send-email-fweisbec@gmail.com> (raw)
In-Reply-To: <1294977121-5700-1-git-send-email-fweisbec@gmail.com>
Some little callchain tree nodes shyly asked me if they can have
sisters.
How cute!
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
---
tools/perf/util/callchain.c | 8 ++++----
tools/perf/util/callchain.h | 4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c
index 5b3f09d..f8c66d1 100644
--- a/tools/perf/util/callchain.c
+++ b/tools/perf/util/callchain.c
@@ -26,10 +26,10 @@ bool ip_callchain__valid(struct ip_callchain *chain, const event_t *event)
}
#define chain_for_each_child(child, parent) \
- list_for_each_entry(child, &parent->children, brothers)
+ list_for_each_entry(child, &parent->children, siblings)
#define chain_for_each_child_safe(child, next, parent) \
- list_for_each_entry_safe(child, next, &parent->children, brothers)
+ list_for_each_entry_safe(child, next, &parent->children, siblings)
static void
rb_insert_callchain(struct rb_root *root, struct callchain_node *chain,
@@ -189,7 +189,7 @@ create_child(struct callchain_node *parent, bool inherit_children)
chain_for_each_child(next, new)
next->parent = new;
}
- list_add_tail(&new->brothers, &parent->children);
+ list_add_tail(&new->siblings, &parent->children);
return new;
}
@@ -419,7 +419,7 @@ merge_chain_branch(struct callchain_cursor *cursor,
if (err)
break;
- list_del(&child->brothers);
+ list_del(&child->siblings);
free(child);
}
diff --git a/tools/perf/util/callchain.h b/tools/perf/util/callchain.h
index 2bb5403..6713725 100644
--- a/tools/perf/util/callchain.h
+++ b/tools/perf/util/callchain.h
@@ -16,7 +16,7 @@ enum chain_mode {
struct callchain_node {
struct callchain_node *parent;
- struct list_head brothers;
+ struct list_head siblings;
struct list_head children;
struct list_head val;
struct rb_node rb_node; /* to sort nodes in an rbtree */
@@ -72,7 +72,7 @@ struct callchain_cursor {
static inline void callchain_init(struct callchain_root *root)
{
- INIT_LIST_HEAD(&root->node.brothers);
+ INIT_LIST_HEAD(&root->node.siblings);
INIT_LIST_HEAD(&root->node.children);
INIT_LIST_HEAD(&root->node.val);
--
1.7.3.2
next prev parent reply other threads:[~2011-01-14 3:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-14 3:51 [PATCH 0/4] perf callchain updates Frederic Weisbecker
2011-01-14 3:51 ` [PATCH 1/4] perf: Feed callchains into a cursor Frederic Weisbecker
2011-01-26 7:20 ` [tip:perf/core] perf callchain: " tip-bot for Frederic Weisbecker
2011-01-14 3:51 ` [PATCH 2/4] perf: Rename cumul_hits into callchain_cumul_hits Frederic Weisbecker
2011-01-26 7:20 ` [tip:perf/core] perf callchain: " tip-bot for Frederic Weisbecker
2011-01-14 3:52 ` [PATCH 3/4] perf: Rename register_callchain_param into callchain_register_param Frederic Weisbecker
2011-01-26 7:21 ` [tip:perf/core] perf callchain: " tip-bot for Frederic Weisbecker
2011-01-14 3:52 ` Frederic Weisbecker [this message]
2011-01-26 7:21 ` [tip:perf/core] perf callchain: Don't give arbitrary gender to callchain tree nodes tip-bot for Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294977121-5700-5-git-send-email-fweisbec@gmail.com \
--to=fweisbec@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox