From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754121Ab1APVok (ORCPT ); Sun, 16 Jan 2011 16:44:40 -0500 Received: from mail.linux-iscsi.org ([67.23.28.174]:38376 "EHLO linux-iscsi.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754083Ab1APVoi (ORCPT ); Sun, 16 Jan 2011 16:44:38 -0500 Subject: Re: [PATCH] configfs: change depends -> select SYSFS From: "Nicholas A. Bellinger" To: Linus Torvalds Cc: linux-kernel , linux-scsi , linux-fsdevel , Joel Becker , Randy Dunlap , James Bottomley , Stephen Rothwell In-Reply-To: References: <1295125851-25279-1-git-send-email-nab@linux-iscsi.org> Content-Type: text/plain Date: Sun, 16 Jan 2011 13:44:33 -0800 Message-Id: <1295214273.22813.48.camel@haakon2.linux-iscsi.org> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2011-01-16 at 09:54 -0800, Linus Torvalds wrote: > On Sat, Jan 15, 2011 at 1:10 PM, Nicholas A. Bellinger > wrote: > > > > This patch changes configfs to select SYSFS to fix the following: > > > > warning: (TARGET_CORE && GFS2_FS) selects CONFIGFS_FS which has unmet direct dependencies (SYSFS) > > I'm ok with this part. But: > > > This patch also fixes whitespace breakage in the 'help' section. > > This is just bogus. The help text is _supposed_ to have that extra > indentation so that it stands out from the rest of the Kconfig stuff. > Ahh, thanks for the clarification here. At some point I saw a patch that did make this change, and it stuck with me that it was the preferred method. This won't happen again. The updated patch to keep the extra indentation for configfs, along with the three extra 'depends CONFIGFS_FS' patches from yesterday are available in a pullable branch against this afternoon's linux-2.6.git/master here: git://git.kernel.org/pub/scm/linux/kernel/git/nab/scsi-post-merge-2.6.git for-linus Please let me know if you have any questions, --nab Nicholas Bellinger (4): configfs: change depends -> select SYSFS net: Make NETCONSOLE_DYNAMIC depend on CONFIGFS_FS dlm: Make DLM depend on CONFIGFS_FS ocfs2: Make OCFS2_FS depend on CONFIGFS_FS drivers/net/Kconfig | 3 +-- fs/configfs/Kconfig | 4 ++-- fs/dlm/Kconfig | 3 +-- fs/ocfs2/Kconfig | 3 +-- 4 files changed, 5 insertions(+), 8 deletions(-)